Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp

Issue 2458233002: Fix under-invalidation on SVG shape/image resize in subpixels (Closed)
Patch Set: - Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
index 266baa1a00c48b4f8aab03fb8e9124c762c500c4..571f0d4e2a8859792260299a3414ae6630b6f48f 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
@@ -184,7 +184,10 @@ void LayoutSVGShape::layout() {
// feeds into the paint invalidation rect - so we need to call it for both
// the shape-update and the bounds-update flag, since .
pdr. 2016/10/31 20:49:05 Not your fault (https://crrev.com/fe8421b9573ca696
Xianzhu 2016/10/31 22:10:30 The fix is in https://codereview.chromium.org/2465
if (m_needsShapeUpdate || m_needsBoundariesUpdate) {
+ FloatRect oldStrokeBoundingBox = strokeBoundingBox();
pdr. 2016/10/31 20:49:05 Are you using the stroke bounding box because it i
Xianzhu 2016/10/31 22:10:30 Used strokeBoundingBox just because it is used for
updateShapeFromElement();
+ if (oldStrokeBoundingBox != strokeBoundingBox())
+ setShouldDoFullPaintInvalidation();
m_needsShapeUpdate = false;
m_paintInvalidationBoundingBox = strokeBoundingBox();

Powered by Google App Engine
This is Rietveld 408576698