Fix under-invalidation on SVG shape/image resize in subpixels

third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp

 /*
  * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org>
  * Copyright (C) 2006 Apple Computer, Inc.
  * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2007, 2008, 2009 Rob Buis <buis@kde.org>
  * Copyright (C) 2009 Google, Inc.
  * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
  * Copyright (C) 2010 Patrick Gansterer <paroga@paroga.com>
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 90 matching lines @@
                 lengthContext.valueForLength(styleRef().height(), styleRef(),
                                              SVGLengthMode::Height));
 
   if (styleRef().width().isAuto() || styleRef().height().isAuto())
     m_objectBoundingBox.setSize(calculateObjectSize());
 
   m_needsBoundariesUpdate |= oldBoundaries != m_objectBoundingBox;
   if (element())
     element()->setNeedsResizeObserverUpdate();
 
+  if (oldBoundaries != m_objectBoundingBox)

[pdr., 2016/10/31 20:49:05]

Can we use m_needsBoundariesUpdate here?

[Xianzhu, 2016/10/31 22:10:30]

It may be true before this check.

Combined the two checks into one 'if'.

+    setShouldDoFullPaintInvalidation();
+
   return oldBoundaries.size() != m_objectBoundingBox.size();
 }
 
 void LayoutSVGImage::layout() {
   ASSERT(needsLayout());
   LayoutAnalyzer::Scope analyzer(*this);
 
   // Invalidate all resources of this client if our layout changed.
   if (everHadLayout() && selfNeedsLayout())
     SVGResourcesCache::clientLayoutChanged(this);
@@ skipping 78 matching lines @@
 
 void LayoutSVGImage::addOutlineRects(Vector<LayoutRect>& rects,
                                      const LayoutPoint&,
                                      IncludeBlockVisualOverflowOrNot) const {
   // this is called from paint() after the localTransform has already been
   // applied
   rects.append(LayoutRect(paintInvalidationRectInLocalSVGCoordinates()));
 }
 
 }  // namespace blink