Issue 2458213002: [Merge-M55] arc: Use overlay to show links from ToS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2458213002: [Merge-M55] arc: Use overlay to show links from ToS. (Closed)

Created:
4 years, 1 month ago by khmel

Modified:
4 years, 1 month ago

Reviewers:
reviewer

CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, alemate+watch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Merge-M55] arc: Use overlay to show links from ToS. BUG=b/32247410 BUG=658833 TEST=Locally on device. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2429793003 Cr-Commit-Position: refs/heads/master@{#426101} (cherry picked from commit 845e02dc39e9283f6a13957bac034c0d4a3d172c)

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -25 lines)			Patch
M	chrome/browser/chromeos/arc/arc_support_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/chromeos/arc_support/background.js	View	7 chunks	+44 lines, -20 lines	0 comments	Download
M	chrome/browser/resources/chromeos/arc_support/main.css	View	1 chunk	+24 lines, -1 line	0 comments	Download
M	chrome/browser/resources/chromeos/arc_support/main.html	View	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458213002/1

4 years, 1 month ago (2016-10-28 21:37:56 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages