Bindings tests should run the same code as prod code.

Bindings tests should run the same code as prod code.

Removed and unified a bunch of code paths (more to go) so that
the bindings tests run more of the same code as what's used to
build Blink.

R=yukishiino, bashi
BUG=654129
Committed: https://crrev.com/fe30a9ea6cfb1ea9e1517ca5de16a8013c5407c8
Cr-Commit-Position: refs/heads/master@{#428584}

[dglazkov, 2016-10-28 21:07:19]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 21:07:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 23:11:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 23:11:02]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2016-10-29 01:24:22]

PTAL.

[haraken, 2016-10-29 01:30:55]

LGTM

FWIW, kolos@ is now moving PasswordManager from content/ to web/. He is planning
to migrate it to web-modules once the infrastructure is ready :) I'm assuming
that the hardest part would be to migrate things from content/ to web/ and that
it would be relatively straightforward to migrate from web/ to web-modules/ (as
long as the feature doesn't require many backdoor APIs).

[dglazkov, 2016-10-29 01:40:05]

The CQ bit was checked by dglazkov@chromium.org

[dglazkov, 2016-10-29 01:40:14]

On 2016/10/29 at 01:30:55, haraken wrote:
> LGTM
> 
> FWIW, kolos@ is now moving PasswordManager from content/ to web/. He is
planning to migrate it to web-modules once the infrastructure is ready :) I'm
assuming that the hardest part would be to migrate things from content/ to web/
and that it would be relatively straightforward to migrate from web/ to
web-modules/ (as long as the feature doesn't require many backdoor APIs).

Awesome!!

[commit-bot: I haz the power, 2016-10-29 01:40:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-29 01:45:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-29 01:48:45]

Description was changed from

==========
Bindings tests should run the same code as prod code.

Removed and unified a bunch of code paths (more to go) so that
the bindings tests run more of the same code as what's used to
build Blink.

R=yukishiino, bashi
BUG=654129
==========

to

==========
Bindings tests should run the same code as prod code.

Removed and unified a bunch of code paths (more to go) so that
the bindings tests run more of the same code as what's used to
build Blink.

R=yukishiino, bashi
BUG=654129

Committed: https://crrev.com/fe30a9ea6cfb1ea9e1517ca5de16a8013c5407c8
Cr-Commit-Position: refs/heads/master@{#428584}
==========

[commit-bot: I haz the power, 2016-10-29 01:48:46]

Patchset 1 (id:??) landed as
https://crrev.com/fe30a9ea6cfb1ea9e1517ca5de16a8013c5407c8
Cr-Commit-Position: refs/heads/master@{#428584}

[bashi, 2016-10-31 22:59:06]

bashi@chromium.org changed reviewers:
+ bashi@chromium.org

[bashi, 2016-10-31 22:59:07]

lgtm. Thanks for the clean-up!

[Yuki, 2016-11-01 13:04:13]

Description was changed from

==========
Bindings tests should run the same code as prod code.

Removed and unified a bunch of code paths (more to go) so that
the bindings tests run more of the same code as what's used to
build Blink.

R=yukishiino, bashi
BUG=654129

Committed: https://crrev.com/fe30a9ea6cfb1ea9e1517ca5de16a8013c5407c8
Cr-Commit-Position: refs/heads/master@{#428584}
==========

to

==========
Bindings tests should run the same code as prod code.

Removed and unified a bunch of code paths (more to go) so that
the bindings tests run more of the same code as what's used to
build Blink.

R=yukishiino, bashi
BUG=654129

Committed: https://crrev.com/fe30a9ea6cfb1ea9e1517ca5de16a8013c5407c8
Cr-Commit-Position: refs/heads/master@{#428584}
==========

[Yuki, 2016-11-01 13:04:13]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org, yukishiino@chromium.org
- bashi@google.com, yukishiino@chromium.or