Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

Issue 2458183002: Eagerly install Origin Trial features on window (Closed)
Patch Set: Rebase before commit Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
index f7163695319eacb7fa3d072f3e915a78949c3a10..95d854acb014c046a7b0b2df61216782a88a3a85 100644
--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
@@ -30,6 +30,7 @@
#include "bindings/core/v8/WindowProxy.h"
+#include "bindings/core/v8/ConditionalFeatures.h"
#include "bindings/core/v8/DOMWrapperWorld.h"
#include "bindings/core/v8/ScriptController.h"
#include "bindings/core/v8/V8Binding.h"
@@ -266,11 +267,6 @@ bool WindowProxy::initialize() {
setSecurityToken(origin);
}
- // All interfaces must be registered to V8PerContextData.
- // So we explicitly call constructorForType for the global object.
- V8PerContextData::from(context)->constructorForType(
- &V8Window::wrapperTypeInfo);
-
if (m_frame->isLocalFrame()) {
LocalFrame* frame = toLocalFrame(m_frame);
MainThreadDebugger::instance()->contextCreated(m_scriptState.get(), frame,
@@ -278,6 +274,12 @@ bool WindowProxy::initialize() {
frame->loader().client()->didCreateScriptContext(
context, m_world->extensionGroup(), m_world->worldId());
}
+ // If conditional features for window have been queued before the V8 context
+ // was ready, then inject them into the context now
+ if (m_world->isMainWorld()) {
+ installPendingConditionalFeaturesOnWindow(m_scriptState.get());
+ }
+
return true;
}

Powered by Google App Engine
This is Rietveld 408576698