Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h

Issue 2458183002: Eagerly install Origin Trial features on window (Closed)
Patch Set: Address comments from PS#7, move ScriptState change to new CL Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h
diff --git a/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h b/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h
index a776a9043befa76b8909766e4ec6e9e94071e239..19552c954c6a32ee42db0cb53e4710103e454e18 100644
--- a/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h
+++ b/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h
@@ -70,11 +70,12 @@ class CORE_EXPORT OriginTrialContext final
// controls) should be considered enabled for the current execution context.
bool isTrialEnabled(const String& trialName);
- // Installs JavaScript bindings for any features which should be enabled by
- // the current set of trial tokens. This method is idempotent; only features
- // which have been enabled since the last time it was run will be installed.
- // If the V8 context for the host execution context has not been
- // initialized, then this method will return without doing anything.
+ // Installs JavaScript bindings on the Window object for any features which
+ // should be enabled by the current set of trial tokens. This method is called
+ // every time a token is added to the document, so that global interfaces will
+ // be properly visible, even if the V8 context is being reused (i.e., after
+ // navigation). If the V8 context is not initialized, this method will return
+ // without doing anything.
void initializePendingFeatures();
DECLARE_VIRTUAL_TRACE();

Powered by Google App Engine
This is Rietveld 408576698