Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp

Issue 2458183002: Eagerly install Origin Trial features on window (Closed)
Patch Set: Address comments from PS#7, move ScriptState change to new CL Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp b/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp
index 3929759df25e58c445070c7e2ccebb37abb477e4..0b4a13a71e21ba05b85dc9948c321b83295d4986 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp
@@ -58,4 +58,13 @@ void installConditionalFeatures(const WrapperTypeInfo* type,
interfaceObject);
}
+void installPendingConditionalFeaturesOnWindow(const ScriptState* scriptState) {
+ DCHECK(scriptState);
+ DCHECK(scriptState->context() == scriptState->isolate()->GetCurrentContext());
+ DCHECK(scriptState->perContextData());
haraken 2016/11/03 16:02:17 Add DCHECK(scriptState->world()->isMainWorld()).
iclelland 2016/11/03 16:43:04 Done. This one is safe (and correct :) )
+ (*s_installConditionalFeaturesFunction)(&V8Window::wrapperTypeInfo,
+ scriptState, v8::Local<v8::Object>(),
+ v8::Local<v8::Function>());
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698