third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp - Issue 2458183002: Eagerly install Origin Trial features on window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

Issue 2458183002: Eagerly install Origin Trial features on window (Closed)

Patch Set: Use correct context and enter it before installing attributes on window Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

diff --git a/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp b/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

index 1638d3625ff9a5c64ef009cdddb30bae22a642f5..efc65df6fe679afa0b89f32fafd251054ce44f10 100644

--- a/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

+++ b/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

@@ -97,8 +97,8 @@ void installConditionalFeaturesForTests(

if (type == &V8OriginTrialsTest::wrapperTypeInfo) {

if (originTrialContext && originTrialContext->isTrialEnabled("Frobulate")) {

V8OriginTrialsTest::installOriginTrialsSampleAPI(

- scriptState->isolate(), scriptState->world(), v8::Local<v8::Object>(),

- prototypeObject, interfaceObject);

+ scriptState, v8::Local<v8::Object>(), prototypeObject,

+ interfaceObject);

}