third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl - Issue 2458183002: Eagerly install Origin Trial features on window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl

Issue 2458183002: Eagerly install Origin Trial features on window (Closed)

Patch Set: Use correct context and enter it before installing attributes on window Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp ('K') | « third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h » ('j') | third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl b/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl

index e813587b24809b7ce0ca77cad0693770601d90a0..11a2c1bf323ec8ea229a2e77ef5cfba2c113dbfc 100644

--- a/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl

@@ -34,10 +34,10 @@ class {{v8_class_or_partial}} {

static void preparePrototypeAndInterfaceObject(v8::Local<v8::Context>, const DOMWrapperWorld&, v8::Local<v8::Object>, v8::Local<v8::Function>, v8::Local<v8::FunctionTemplate>);

{% endif %}

{% for origin_trial_feature in origin_trial_features %}{{newline}}

- static void install{{origin_trial_feature.name}}(ScriptState*, v8::Local<v8::Object> instance);

- static void install{{origin_trial_feature.name}}(v8::Isolate*, const DOMWrapperWorld&, v8::Local<v8::Object> instance, v8::Local<v8::Object> prototype, v8::Local<v8::Function> interface);

+ static void install{{origin_trial_feature.name}}(const ScriptState*, v8::Local<v8::Object> instance);

+ static void install{{origin_trial_feature.name}}(const ScriptState*, v8::Local<v8::Object> instance, v8::Local<v8::Object> prototype, v8::Local<v8::Function> interface);

{% if not origin_trial_feature.needs_instance %}

- static void install{{origin_trial_feature.name}}(ScriptState*);

+ static void install{{origin_trial_feature.name}}(const ScriptState*);

{% endif %}

{% endfor %}

private: