Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp

Issue 2458183002: Eagerly install Origin Trial features on window (Closed)
Patch Set: Use correct context and enter it before installing attributes on window Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp b/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp
index 3929759df25e58c445070c7e2ccebb37abb477e4..9958dea13338ef25acf3cdd8cb7bf19481d89db9 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp
@@ -30,8 +30,8 @@ void installConditionalFeaturesCore(const WrapperTypeInfo* wrapperTypeInfo,
(originTrialContext &&
originTrialContext->isTrialEnabled("ForeignFetch"))) {
V8HTMLLinkElement::installLinkServiceWorker(
- scriptState->isolate(), scriptState->world(), v8::Local<v8::Object>(),
- prototypeObject, interfaceObject);
+ scriptState, v8::Local<v8::Object>(), prototypeObject,
+ interfaceObject);
}
}
}
@@ -58,4 +58,13 @@ void installConditionalFeatures(const WrapperTypeInfo* type,
interfaceObject);
}
+void installPendingConditionalFeaturesOnWindow(const ScriptState* scriptState) {
+ DCHECK(scriptState);
+ DCHECK(scriptState->context() == scriptState->isolate()->GetCurrentContext());
+ DCHECK(scriptState->perContextData());
+ (*s_installConditionalFeaturesFunction)(&V8Window::wrapperTypeInfo,
+ scriptState, v8::Local<v8::Object>(),
+ v8::Local<v8::Function>());
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698