Eagerly install Origin Trial features on window

third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

 /*
  * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 12 matching lines @@
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "bindings/core/v8/WindowProxy.h"
 
+#include "bindings/core/v8/ConditionalFeatures.h"
 #include "bindings/core/v8/DOMWrapperWorld.h"
 #include "bindings/core/v8/ScriptController.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/core/v8/V8DOMActivityLogger.h"
 #include "bindings/core/v8/V8Document.h"
 #include "bindings/core/v8/V8GCForContextDispose.h"
 #include "bindings/core/v8/V8HTMLCollection.h"
 #include "bindings/core/v8/V8HTMLDocument.h"
 #include "bindings/core/v8/V8HiddenValue.h"
 #include "bindings/core/v8/V8Initializer.h"
@@ skipping 213 matching lines @@
     context->AllowCodeGenerationFromStrings(
         csp->allowEval(0, ContentSecurityPolicy::SuppressReport));
     context->SetErrorMessageForCodeGenerationFromStrings(
         v8String(m_isolate, csp->evalDisabledErrorMessage()));
   } else {
     updateActivityLogger();
     origin = m_world->isolatedWorldSecurityOrigin();
     setSecurityToken(origin);
   }
 
-  // All interfaces must be registered to V8PerContextData.
-  // So we explicitly call constructorForType for the global object.
-  V8PerContextData::from(context)->constructorForType(
-      &V8Window::wrapperTypeInfo);
-
   if (m_frame->isLocalFrame()) {
     LocalFrame* frame = toLocalFrame(m_frame);
     MainThreadDebugger::instance()->contextCreated(m_scriptState.get(), frame,
                                                    origin);
     frame->loader().client()->didCreateScriptContext(
         context, m_world->extensionGroup(), m_world->worldId());
   }
+  // If conditional features for window have been queued before the V8 context
+  // was ready, then inject them into the context now
+  installPendingConditionalFeaturesOnWindow(m_scriptState.get());

[haraken, 2016/11/03 14:43:07]

Just help me understand: Who prevents us from installing origin-trial settings
on isolated worlds? I'm assuming that you don't want to enable origin-trials on
isolated worlds.

[iclelland, 2016/11/03 16:00:01]

We don't want to do that -- thanks for catching it. It caused problems in the
past (crbug.com/619465 for one) and we had to explicitly remove them. I'll add
the check back in here until we've determined that that issue is fixed.

I do eventually want to make it possible to support this kind of conditional
binding in isolated worlds -- not for origin trials, but for other work, like
Feature Policy. For now, I'll add that check.

+
   return true;
 }
 
 void WindowProxy::createContext() {
   // FIXME: This should be a null check of m_frame->client(), but there are
   // still some edge cases
   // that this fails to catch during frame detach.
   if (m_frame->isLocalFrame() &&
       !toLocalFrame(m_frame)->loader().documentLoader())
     return;
@@ skipping 289 matching lines @@
                          v8String(m_isolate, name));
 }
 
 void WindowProxy::updateSecurityOrigin(SecurityOrigin* origin) {
   if (!isContextInitialized())
     return;
   setSecurityToken(origin);
 }
 
 }  // namespace blink