Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2458123003: Remove DHECiphers feature flag. (Closed)

Created:
4 years, 1 month ago by davidben
Modified:
4 years, 1 month ago
Reviewers:
svaldez
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DHECiphers feature flag. This was an emergency off switch should the DHE removal not stick. That went through fine, so remove the feature glue. The remaining glue is still needed and will be deleted in a few cycles when the admin policy expires. BUG=619194 Committed: https://crrev.com/d6b73e400dd0d62664f7fe178d506032b881b2ad Cr-Commit-Position: refs/heads/master@{#428485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M components/ssl_config/ssl_config_service_manager_pref.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M components/ssl_config/ssl_config_service_manager_pref_unittest.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
davidben
4 years, 1 month ago (2016-10-28 19:56:10 UTC) #4
svaldez
lgtm
4 years, 1 month ago (2016-10-28 19:57:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458123003/1
4 years, 1 month ago (2016-10-28 19:58:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 20:55:51 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 21:00:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6b73e400dd0d62664f7fe178d506032b881b2ad
Cr-Commit-Position: refs/heads/master@{#428485}

Powered by Google App Engine
This is Rietveld 408576698