ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js - Issue 2458113003: Prevent bogus 'search-changed' event firing from cr_search_field_behavior.js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

Issue 2458113003: Prevent bogus 'search-changed' event firing from cr_search_field_behavior.js. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js ('K') | « chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

diff --git a/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js b/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

index a5137e88ed11bf0d83c53d3f53eec68535092ea2..a5bcce9f121355e9aef608f6519e87b5988f82f6 100644

--- a/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

+++ b/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

@@ -93,7 +93,11 @@ var CrSearchFieldBehavior = {

/** @private */

Dan Beam 2016/10/28 20:54:06 can we annotate @params here?

dpapad 2016/10/28 21:12:13 Done.

- showingSearchChanged_: function() {

+ showingSearchChanged_: function(current, previous) {

+ // Prevent bogus 'search-changed' event from firing on startup.

Dan Beam 2016/10/28 20:54:06 s/bogus/initial

dpapad 2016/10/28 21:12:13 Done, actually s/bogus/unnecessary, I think this b

+ if (previous == undefined)

+ return;

if (this.showingSearch) {

this.focus_();

return;