Chromium Code Reviews Chromium Code Reviews
Issue 2458033003:
DevTools: introduce --custom-devtools-frontend flag. (Closed)
| Index: chrome/browser/devtools/frontend/devtools_discovery_page.html |
| diff --git a/chrome/browser/devtools/frontend/devtools_discovery_page.html b/chrome/browser/devtools/frontend/devtools_discovery_page.html |
| index d6d9fb01ce793c36d1c340f1adc5139924a9c84b..b81844d7798dcb56909767ceaf8e6f0646490154 100644 |
| --- a/chrome/browser/devtools/frontend/devtools_discovery_page.html |
| +++ b/chrome/browser/devtools/frontend/devtools_discovery_page.html |
| @@ -84,24 +84,13 @@ function onReady() { |
| } |
| } |
| -function overrideFrontendUrl(item) { |
| - if (window.location.hash) { |
| - var overridden_url = window.location.hash.substr(1); |
| - var ws_suffix = item.webSocketDebuggerUrl.replace('ws://', 'ws='); |
| - if (overridden_url.indexOf('?') == -1) |
| - return overridden_url + '?' + ws_suffix; |
| - else |
| - return overridden_url + '&' + ws_suffix; |
| - } |
| - return item.devtoolsFrontendUrl; |
| -} |
| - |
| function appendItem(item_object) { |
| var item_element; |
| if (item_object.devtoolsFrontendUrl) { |
| item_element = document.createElement('a'); |
| - item_element.href = overrideFrontendUrl(item_object); |
| + item_element.href = item_object.devtoolsFrontendUrl; |
| item_element.title = item_object.title; |
| + item_element.addEventListener('click', onItemClicked.bind(null, item_element.href)); |
| } else { |
| item_element = document.createElement('div'); |
| item_element.className = 'connected'; |
| @@ -128,6 +117,13 @@ function appendItem(item_object) { |
| document.getElementById('items').appendChild(item_element); |
| } |
| + |
| +function onItemClicked(url, event) { |
| + fetch("/json/new?" + url); |
|
dgozman
2016/10/30 03:14:46
What is this doing?
lushnikov
2016/10/31 22:47:26
Since we cannot navigate to chrome-devtools scheme
|
| + event.preventDefault(); |
| + event.stopPropagation(); |
| +} |
| + |
| </script> |
| </head> |
| <body onload='onLoad()'> |
