DevTools: introduce --custom-devtools-frontend flag.

DevTools: introduce --custom-devtools-frontend flag.

This patch introduces the --custom-devtools-frontend flag
with a value of an HTTP endpoint which should serve
devtools front-end.

With this flag, the custom front-end will be available
under the chrome-devtools://devtools/custom/inspector.html.
This front-end will get devtools bindings, which basically
means it's a full-featured hosted mode.

Example use:

   chrome --custom-devtools-frontend=http://localhost:8090/front_end

In order to make a use of the new flag, the remote debugging
front-end page can point to the custom devtools url. In order to do
so, it should be provided a special hash value:

   localhost:9222#custom=true&experiments=true

BUG=629914
R=pfeldman, dgozman

Committed: https://crrev.com/359abf8463487cc61c260b34053a14022185f7f9
Cr-Commit-Position: refs/heads/master@{#429064}

[lushnikov, 2016-10-29 00:25:38]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[lushnikov, 2016-10-29 00:25:44]

please, take a look

[commit-bot: I haz the power, 2016-10-29 00:26:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-29 02:12:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-29 02:12:29]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-10-29 03:22:05]

Description was changed from

==========
DevTools: introduce --remote-debugging-frontend flag.

This patch introduces the --remote-debugging-frontend flag with a value
of an HTTP endpoint which serves devtools front-end. This front-end will
be used only to power remote debugging sessions.

Example use:

   chrome --remote-debugging-port=9222
--remote-debugging-frontend=http://localhost:8090/front_end

As a result, navigating chrome instance to the localhost:9222 and
opening tab for remote-debugging inspection will load the devtools
front-end from the endpoint on localhost:8090.

This patch also makes hosted mode unneeded. As a result,
InspectorBackendHostedMode could be removed.

BUG=none
R=pfeldman, dgozman
==========

to

==========
DevTools: introduce --remote-debugging-frontend flag.

This patch introduces the --remote-debugging-frontend flag with a value
of an HTTP endpoint which serves devtools front-end. This front-end will
be used only to power remote debugging sessions.

Example use:

   chrome --remote-debugging-port=9222
--remote-debugging-frontend=http://localhost:8090/front_end

As a result, navigating chrome instance to the localhost:9222 and
opening tab for remote-debugging inspection will load the devtools
front-end from the endpoint on localhost:8090.

BUG=none
R=pfeldman, dgozman
==========

[lushnikov, 2016-10-29 03:23:09]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-29 03:23:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-29 04:09:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-29 04:09:24]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-10-30 03:14:47]

Could you please recap the benefits of this approach?

https://codereview.chromium.org/2458033003/diff/40001/chrome/browser/devtools...
File chrome/browser/devtools/frontend/devtools_discovery_page.html (right):

https://codereview.chromium.org/2458033003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/frontend/devtools_discovery_page.html:122:
fetch("/json/new?" + url);
What is this doing?

https://codereview.chromium.org/2458033003/diff/40001/chrome/browser/devtools...
File chrome/browser/devtools/remote_debugging_server.cc (right):

https://codereview.chromium.org/2458033003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/remote_debugging_server.cc:118: frontend_url =
chrome::kChromeUIDevToolsCustomURL;
So, this relies on the remote browser to support this custom url? Sounds
strange.

https://codereview.chromium.org/2458033003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/remote_debugging_server.cc:120: frontend_url +=
"?experiments=true";
Can we make hosting browser to add all the parameters, e.g. remoteBase,
experiments, etc?

[lushnikov, 2016-10-31 22:46:29]

Description was changed from

==========
DevTools: introduce --remote-debugging-frontend flag.

This patch introduces the --remote-debugging-frontend flag with a value
of an HTTP endpoint which serves devtools front-end. This front-end will
be used only to power remote debugging sessions.

Example use:

   chrome --remote-debugging-port=9222
--remote-debugging-frontend=http://localhost:8090/front_end

As a result, navigating chrome instance to the localhost:9222 and
opening tab for remote-debugging inspection will load the devtools
front-end from the endpoint on localhost:8090.

BUG=none
R=pfeldman, dgozman
==========

to

==========
DevTools: introduce --custom-devtools-frontend flag.

This patch introduces the --custom-devtools-frontend flag
with a value of an HTTP endpoint which should serve
devtools front-end.

With this flag, the custom front-end will be available
under the chrome-devtools://devtools/custom/inspector.html.
This front-end will get devtools bindings, which basically
means it's a full-featured hosted mode.

Example use:

   chrome --custom-devtools-frontend=http://localhost:8090/front_end

In order to make a use of the new flag, the remote debugging
front-end page can point to the custom devtools url. In order to do
so, it should be provided a special hash value:

   localhost:9222#custom=true&experiments=true

BUG=none
R=pfeldman, dgozman
==========

[lushnikov, 2016-10-31 22:47:26]

https://codereview.chromium.org/2458033003/diff/40001/chrome/browser/devtools...
File chrome/browser/devtools/frontend/devtools_discovery_page.html (right):

https://codereview.chromium.org/2458033003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/frontend/devtools_discovery_page.html:122:
fetch("/json/new?" + url);
On 2016/10/30 03:14:46, dgozman wrote:
> What is this doing?

Since we cannot navigate to chrome-devtools scheme, this sends a command to
devtools_http_handler to open a new tab with given url.

https://codereview.chromium.org/2458033003/diff/40001/chrome/browser/devtools...
File chrome/browser/devtools/remote_debugging_server.cc (right):

https://codereview.chromium.org/2458033003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/remote_debugging_server.cc:118: frontend_url =
chrome::kChromeUIDevToolsCustomURL;
On 2016/10/30 03:14:46, dgozman wrote:
> So, this relies on the remote browser to support this custom url? Sounds
> strange.

Done.

https://codereview.chromium.org/2458033003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/remote_debugging_server.cc:120: frontend_url +=
"?experiments=true";
On 2016/10/30 03:14:46, dgozman wrote:
> Can we make hosting browser to add all the parameters, e.g. remoteBase,
> experiments, etc?

Done.

[dgozman, 2016-10-31 23:11:32]

lgtm

https://codereview.chromium.org/2458033003/diff/80001/chrome/browser/devtools...
File chrome/browser/devtools/frontend/devtools_discovery_page.html (right):

https://codereview.chromium.org/2458033003/diff/80001/chrome/browser/devtools...
chrome/browser/devtools/frontend/devtools_discovery_page.html:143:
fetch("/json/new?" + anchor.href);
Just do a preselected copy-paste.

https://codereview.chromium.org/2458033003/diff/80001/chrome/common/chrome_sw...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/2458033003/diff/80001/chrome/common/chrome_sw...
chrome/common/chrome_switches.cc:149: //
chrome-devtools://devtools/custom/inspector.html.
chrome-devtools://devtools/custom/<path>

https://codereview.chromium.org/2458033003/diff/80001/chrome/common/chrome_sw...
chrome/common/chrome_switches.cc:838: 
revert

https://codereview.chromium.org/2458033003/diff/80001/chrome/common/url_const...
File chrome/common/url_constants.cc (right):

https://codereview.chromium.org/2458033003/diff/80001/chrome/common/url_const...
chrome/common/url_constants.cc:41: const char kChromeUIDevToolsCustomURL[] =
Sort please.

[lushnikov, 2016-10-31 23:15:40]

Description was changed from

==========
DevTools: introduce --custom-devtools-frontend flag.

This patch introduces the --custom-devtools-frontend flag
with a value of an HTTP endpoint which should serve
devtools front-end.

With this flag, the custom front-end will be available
under the chrome-devtools://devtools/custom/inspector.html.
This front-end will get devtools bindings, which basically
means it's a full-featured hosted mode.

Example use:

   chrome --custom-devtools-frontend=http://localhost:8090/front_end

In order to make a use of the new flag, the remote debugging
front-end page can point to the custom devtools url. In order to do
so, it should be provided a special hash value:

   localhost:9222#custom=true&experiments=true

BUG=none
R=pfeldman, dgozman
==========

to

==========
DevTools: introduce --custom-devtools-frontend flag.

This patch introduces the --custom-devtools-frontend flag
with a value of an HTTP endpoint which should serve
devtools front-end.

With this flag, the custom front-end will be available
under the chrome-devtools://devtools/custom/inspector.html.
This front-end will get devtools bindings, which basically
means it's a full-featured hosted mode.

Example use:

   chrome --custom-devtools-frontend=http://localhost:8090/front_end

In order to make a use of the new flag, the remote debugging
front-end page can point to the custom devtools url. In order to do
so, it should be provided a special hash value:

   localhost:9222#custom=true&experiments=true

BUG=629914
R=pfeldman, dgozman
==========

[lushnikov, 2016-11-01 00:19:40]

https://codereview.chromium.org/2458033003/diff/80001/chrome/browser/devtools...
File chrome/browser/devtools/frontend/devtools_discovery_page.html (right):

https://codereview.chromium.org/2458033003/diff/80001/chrome/browser/devtools...
chrome/browser/devtools/frontend/devtools_discovery_page.html:143:
fetch("/json/new?" + anchor.href);
On 2016/10/31 23:11:32, dgozman wrote:
> Just do a preselected copy-paste.

Done. Screenshot: https://goo.gl/Xx4kdr

https://codereview.chromium.org/2458033003/diff/80001/chrome/common/chrome_sw...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/2458033003/diff/80001/chrome/common/chrome_sw...
chrome/common/chrome_switches.cc:149: //
chrome-devtools://devtools/custom/inspector.html.
On 2016/10/31 23:11:32, dgozman wrote:
> chrome-devtools://devtools/custom/<path>

Done.

https://codereview.chromium.org/2458033003/diff/80001/chrome/common/chrome_sw...
chrome/common/chrome_switches.cc:838: 
On 2016/10/31 23:11:32, dgozman wrote:
> revert

Done.

https://codereview.chromium.org/2458033003/diff/80001/chrome/common/url_const...
File chrome/common/url_constants.cc (right):

https://codereview.chromium.org/2458033003/diff/80001/chrome/common/url_const...
chrome/common/url_constants.cc:41: const char kChromeUIDevToolsCustomURL[] =
On 2016/10/31 23:11:32, dgozman wrote:
> Sort please.

Done.

[lushnikov, 2016-11-01 00:19:53]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 00:20:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 01:49:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 01:49:18]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-11-01 17:56:49]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-11-01 17:56:49]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2458033003/#ps100001
(title: "address comments")

[commit-bot: I haz the power, 2016-11-01 17:57:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 18:04:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 18:04:27]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2016-11-01 18:40:31]

lgtm

[lushnikov, 2016-11-01 18:48:43]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-11-01 18:49:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 18:58:55]

Description was changed from

==========
DevTools: introduce --custom-devtools-frontend flag.

This patch introduces the --custom-devtools-frontend flag
with a value of an HTTP endpoint which should serve
devtools front-end.

With this flag, the custom front-end will be available
under the chrome-devtools://devtools/custom/inspector.html.
This front-end will get devtools bindings, which basically
means it's a full-featured hosted mode.

Example use:

   chrome --custom-devtools-frontend=http://localhost:8090/front_end

In order to make a use of the new flag, the remote debugging
front-end page can point to the custom devtools url. In order to do
so, it should be provided a special hash value:

   localhost:9222#custom=true&experiments=true

BUG=629914
R=pfeldman, dgozman
==========

to

==========
DevTools: introduce --custom-devtools-frontend flag.

This patch introduces the --custom-devtools-frontend flag
with a value of an HTTP endpoint which should serve
devtools front-end.

With this flag, the custom front-end will be available
under the chrome-devtools://devtools/custom/inspector.html.
This front-end will get devtools bindings, which basically
means it's a full-featured hosted mode.

Example use:

   chrome --custom-devtools-frontend=http://localhost:8090/front_end

In order to make a use of the new flag, the remote debugging
front-end page can point to the custom devtools url. In order to do
so, it should be provided a special hash value:

   localhost:9222#custom=true&experiments=true

BUG=629914
R=pfeldman, dgozman
==========

[commit-bot: I haz the power, 2016-11-01 18:58:58]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-01 19:29:03]

Description was changed from

==========
DevTools: introduce --custom-devtools-frontend flag.

This patch introduces the --custom-devtools-frontend flag
with a value of an HTTP endpoint which should serve
devtools front-end.

With this flag, the custom front-end will be available
under the chrome-devtools://devtools/custom/inspector.html.
This front-end will get devtools bindings, which basically
means it's a full-featured hosted mode.

Example use:

   chrome --custom-devtools-frontend=http://localhost:8090/front_end

In order to make a use of the new flag, the remote debugging
front-end page can point to the custom devtools url. In order to do
so, it should be provided a special hash value:

   localhost:9222#custom=true&experiments=true

BUG=629914
R=pfeldman, dgozman
==========

to

==========
DevTools: introduce --custom-devtools-frontend flag.

This patch introduces the --custom-devtools-frontend flag
with a value of an HTTP endpoint which should serve
devtools front-end.

With this flag, the custom front-end will be available
under the chrome-devtools://devtools/custom/inspector.html.
This front-end will get devtools bindings, which basically
means it's a full-featured hosted mode.

Example use:

   chrome --custom-devtools-frontend=http://localhost:8090/front_end

In order to make a use of the new flag, the remote debugging
front-end page can point to the custom devtools url. In order to do
so, it should be provided a special hash value:

   localhost:9222#custom=true&experiments=true

BUG=629914
R=pfeldman, dgozman

Committed: https://crrev.com/359abf8463487cc61c260b34053a14022185f7f9
Cr-Commit-Position: refs/heads/master@{#429064}
==========

[commit-bot: I haz the power, 2016-11-01 19:29:05]

Patchset 6 (id:??) landed as
https://crrev.com/359abf8463487cc61c260b34053a14022185f7f9
Cr-Commit-Position: refs/heads/master@{#429064}