Use the new dll injection blocking api of the sandbox to block...

Use the new dll injection blocking api of the sandbox to block
the loading of dlls that cause renderer crashes.
- Remove the old FreeLibrary() method


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2441

[rvargas (doing something else), 2008-09-16 00:32:04]

lgtm

http://codereview.chromium.org/2458/diff/407/608
File chrome/browser/sandbox_policy.cc (right):

http://codereview.chromium.org/2458/diff/407/608#newcode110
Line 110: LOG(WARNING) << "dll to unload found: " << ix;
Do you want lo log the dll name?

http://codereview.chromium.org/2458/diff/407/607
File chrome/browser/sandbox_policy.h (right):

http://codereview.chromium.org/2458/diff/407/607#newcode47
Line 47: #endif  // CHROME_BROWSER_SANDBOX_POLICY_H__
nit: Please update the guard.

[amit, 2008-09-16 15:07:07]

LGTM with comments. 

I think reading the list from external source is kind of tricky in sandbox, but
I think it's worth the effort.

http://codereview.chromium.org/2458/diff/407/608
File chrome/browser/sandbox_policy.cc (right):

http://codereview.chromium.org/2458/diff/407/608#newcode104
Line 104: };
Ideally, this list should be picked up from a source that can be updated
independently of code (XML). This might be worth the effort as we can respond to
issues by quickly updating the data instead of building a new patch.

[cpu_(ooo_6.6-7.5), 2008-09-17 02:43:56]

I have updated the code with the comments. 

I want to not implement a sandbox configuration file yet because of the
considerations outlined last year, namely we don't want people to change this by
themselves or we would need to make it way more sophisticated to be really
helpful. For example if somebody adds a rule, it must be preserved (merged with
new rules) when chrome upgrades.

I think the right time to do this with some planning is when we have a plan to
sandbox plugins. Right now a fixed list in the code supports our needs quite
well.

Another more interesting idea is not to have a config file but query our
servers. We sort of do this today for plug-ins.