Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3526)

Issue 2457983003: Disable TestAppViewWithUndefinedDataShouldSucceed on chrome OS (Closed)

Created:
4 years, 1 month ago by xidachen
Modified:
4 years, 1 month ago
Reviewers:
lfg
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable TestAppViewWithUndefinedDataShouldSucceed on chrome OS This is observed here: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/28564 TBR=lfg@chromium.org NOTRY=true BUG=660366 Committed: https://crrev.com/ed9d17790ce6f192dd1eb06737fa111432e5d0a1 Cr-Commit-Position: refs/heads/master@{#428400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M extensions/browser/guest_view/app_view/app_view_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457983003/1
4 years, 1 month ago (2016-10-28 17:02:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 17:08:36 UTC) #3
lfg
At this point we should probably disable it on all platforms.
4 years, 1 month ago (2016-10-28 17:09:39 UTC) #4
xidachen
On 2016/10/28 17:09:39, lfg wrote: > At this point we should probably disable it on ...
4 years, 1 month ago (2016-10-28 17:11:04 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 17:22:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed9d17790ce6f192dd1eb06737fa111432e5d0a1
Cr-Commit-Position: refs/heads/master@{#428400}

Powered by Google App Engine
This is Rietveld 408576698