Remove stl_util's deletion function use and ScopedVector from chrome/browser/download/.

Remove stl_util's deletion function use and ScopedVector from chrome/browser/download/.

BUG=555865, 554289
Committed: https://crrev.com/aa346b0d110225fdc80629750c2e5ccafe2e2a49
Cr-Commit-Position: refs/heads/master@{#428369}

[Avi (use Gerrit), 2016-10-27 20:19:52]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 20:21:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-10-27 20:23:39]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 20:23:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-10-27 21:16:29]

avi@chromium.org changed reviewers:
+ thakis@chromium.org

[commit-bot: I haz the power, 2016-10-27 21:33:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 21:33:56]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-10-28 03:53:38]

avi@chromium.org changed reviewers:
+ sky@chromium.org
- thakis@chromium.org

[Avi (use Gerrit), 2016-10-28 03:53:39]

Nico's out until Monday. Scott, you comfortable taking this?

[sky, 2016-10-28 13:33:59]

LGTM

https://codereview.chromium.org/2457923002/diff/20001/chrome/browser/download...
File chrome/browser/download/download_query_unittest.cc (right):

https://codereview.chromium.org/2457923002/diff/20001/chrome/browser/download...
chrome/browser/download/download_query_unittest.cc:105:
std::vector<content::MockDownloadItem*> mocks_;
It's unfortunate that two vectors with the same thing are necessary here. Please
add a comment.

https://codereview.chromium.org/2457923002/diff/20001/chrome/browser/download...
File chrome/browser/download/download_status_updater.cc (right):

https://codereview.chromium.org/2457923002/diff/20001/chrome/browser/download...
chrome/browser/download/download_status_updater.cc:73: for (auto item : items) {
auto*

https://codereview.chromium.org/2457923002/diff/20001/chrome/browser/download...
chrome/browser/download/download_status_updater.cc:98: for (auto item : items) {
no {} and auto*

https://codereview.chromium.org/2457923002/diff/20001/chrome/browser/download...
File chrome/browser/download/download_status_updater_unittest.cc (right):

https://codereview.chromium.org/2457923002/diff/20001/chrome/browser/download...
chrome/browser/download/download_status_updater_unittest.cc:172: // items of
that manager. The inner vector is a vector<DownloadItem*> for
Thanks for the comment!

[Avi (use Gerrit), 2016-10-28 14:02:00]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 14:02:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-10-28 14:04:10]

https://codereview.chromium.org/2457923002/diff/20001/chrome/browser/download...
File chrome/browser/download/download_query_unittest.cc (right):

https://codereview.chromium.org/2457923002/diff/20001/chrome/browser/download...
chrome/browser/download/download_query_unittest.cc:105:
std::vector<content::MockDownloadItem*> mocks_;
On 2016/10/28 13:33:59, sky wrote:
> It's unfortunate that two vectors with the same thing are necessary here.
Please
> add a comment.

Done.

https://codereview.chromium.org/2457923002/diff/20001/chrome/browser/download...
File chrome/browser/download/download_status_updater.cc (right):

https://codereview.chromium.org/2457923002/diff/20001/chrome/browser/download...
chrome/browser/download/download_status_updater.cc:73: for (auto item : items) {
On 2016/10/28 13:33:59, sky wrote:
> auto*

Done.

https://codereview.chromium.org/2457923002/diff/20001/chrome/browser/download...
chrome/browser/download/download_status_updater.cc:98: for (auto item : items) {
On 2016/10/28 13:33:59, sky wrote:
> no {} and auto*

Done.

https://codereview.chromium.org/2457923002/diff/20001/chrome/browser/download...
File chrome/browser/download/download_status_updater_unittest.cc (right):

https://codereview.chromium.org/2457923002/diff/20001/chrome/browser/download...
chrome/browser/download/download_status_updater_unittest.cc:172: // items of
that manager. The inner vector is a vector<DownloadItem*> for
On 2016/10/28 13:33:59, sky wrote:
> Thanks for the comment!

Acknowledged.

[Avi (use Gerrit), 2016-10-28 14:20:24]

The CQ bit was unchecked by avi@chromium.org

[Avi (use Gerrit), 2016-10-28 14:20:27]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-10-28 14:20:28]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2457923002/#ps40001
(title: "sky")

[commit-bot: I haz the power, 2016-10-28 14:20:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 14:53:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-28 14:55:04]

Description was changed from

==========
Remove stl_util's deletion function use and ScopedVector from
chrome/browser/download/.

BUG=555865, 554289
==========

to

==========
Remove stl_util's deletion function use and ScopedVector from
chrome/browser/download/.

BUG=555865, 554289

Committed: https://crrev.com/aa346b0d110225fdc80629750c2e5ccafe2e2a49
Cr-Commit-Position: refs/heads/master@{#428369}
==========

[commit-bot: I haz the power, 2016-10-28 14:55:05]

Patchset 3 (id:??) landed as
https://crrev.com/aa346b0d110225fdc80629750c2e5ccafe2e2a49
Cr-Commit-Position: refs/heads/master@{#428369}