Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 24579003: Clean up remaining unused globals (on mac). (Closed)

Created:
7 years, 2 months ago by Nico
Modified:
7 years, 2 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), jam, amit, browser-components-watch_chromium.org, piman+watch_chromium.org, markusheintz_, aandrey+blink_chromium.org, Ilya Sherman, miu+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, vsevik, benquan, kkania, apatrick_chromium, joi+watch-content_chromium.org, marja+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, Greg Billock, dcaiafa+watch_chromium.org, wez+watch_chromium.org, sanjeevr, haitaol+watch_chromium.org, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, Albert Bodenhamer, sergeyu+watch_chromium.org, alexeypa+watch_chromium.org, rouslan+autofillwatch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, rsimha+watch_chromium.org, Lei Zhang, tfarina, frankf, yurys, garykac+watch_chromium.org, tommycli, lambroslambrou+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, cc-bugs_chromium.org, James Su, wjia+watch_chromium.org, jshin+watch_chromium.org, pfeldman
Visibility:
Public.

Description

Clean up remaining unused globals (on mac). Found by clang's new -Wunused-const-variable. BUG=290204 R=akalin@chromium.org, jamesr@chromium.org, koz@chromium.org, piman@chromium.org, sergeyu@chromium.org, thestig@chromium.org, vitalybuka@chromium.org TBR=cpu, dmichael, joi, xhwang Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225281

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : staticmedia #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -332 lines) Patch
M apps/shell_window_geometry_cache_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/captive_portal/captive_portal_service_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/identity/experimental_identity_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc View 1 chunk +12 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_apitest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/app_sync_data_unittest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +13 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data_unittest.cc View 3 chunks +6 lines, -19 lines 0 comments Download
M chrome/browser/extensions/extension_warning_badge_service_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/history/typed_url_syncable_service_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/importer/firefox_importer_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 1 chunk +11 lines, -9 lines 0 comments Download
M chrome/browser/media/encrypted_media_istypesupported_browsertest.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/browser/net/predictor_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/notifications/sync_notifier/chrome_notifier_delegate_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_unittest_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_types_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_section_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell_unittest.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/login/login_prompt_browsertest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/chromedriver/net/adb_client_socket.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cloud_print/service/service_state.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M components/autofill/core/browser/password_autofill_manager_unittest.cc View 1 chunk +5 lines, -11 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher_unittest.cc View 1 chunk +5 lines, -17 lines 0 comments Download
M gpu/config/gpu_control_list_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M jingle/glue/pseudotcp_adapter_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/audio/audio_output_device_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/audio_renderer_mixer_unittest.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M media/base/pipeline_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/cdm/aes_decryptor_unittest.cc View 7 chunks +20 lines, -22 lines 0 comments Download
M media/cdm/ppapi/clear_key_cdm.cc View 1 2 2 chunks +7 lines, -8 lines 0 comments Download
M media/filters/audio_renderer_algorithm_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M media/filters/pipeline_integration_test.cc View 1 chunk +34 lines, -30 lines 0 comments Download
M media/webm/webm_tracks_parser_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/tools/dump_cache/dump_cache.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M ppapi/tests/test_audio.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/tests/test_fullscreen.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/tests/test_tcp_server_socket_private.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ppapi/tests/test_websocket.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/base/auto_thread_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/config_file_watcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/register_support_host_request_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/server_log_entry.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M remoting/host/service_urls.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M skia/ext/platform_canvas_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M sync/engine/syncer_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sync/tools/sync_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sync/tools/sync_listen_notifications.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/cld/encodings/compact_lang_det/compact_lang_det_unittest_small.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Nico
Last (large) one! koz: apps/ jamesr: cc/ thestig: chrome/ vitalybuka: cloud_print/ joi: components/, content/, google_apis/ ...
7 years, 2 months ago (2013-09-25 22:49:14 UTC) #1
Sergey Ulanov
remoting and jingle - LGTM
7 years, 2 months ago (2013-09-25 23:00:18 UTC) #2
Lei Zhang
chrome/ lgtm
7 years, 2 months ago (2013-09-25 23:05:09 UTC) #3
Vitaly Buka (NO REVIEWS)
lgtm
7 years, 2 months ago (2013-09-25 23:07:06 UTC) #4
jamesr
lgtm
7 years, 2 months ago (2013-09-25 23:13:47 UTC) #5
akalin
net and sync lgtm
7 years, 2 months ago (2013-09-25 23:13:53 UTC) #6
piman
gpu LGTM
7 years, 2 months ago (2013-09-25 23:41:09 UTC) #7
koz (OOO until 15th September)
chrome/browser/extensions lgtm
7 years, 2 months ago (2013-09-26 00:02:45 UTC) #8
Nico
Committed patchset #3 manually as r225281 (presubmit successful).
7 years, 2 months ago (2013-09-26 00:06:52 UTC) #9
dmichael (off chromium)
late to the game, but ppapi lgtm
7 years, 2 months ago (2013-09-26 02:18:16 UTC) #10
Jói
LGTM, but note I am not an OWNER for //content/browser.
7 years, 2 months ago (2013-09-26 10:08:27 UTC) #11
piman
7 years, 2 months ago (2013-09-26 17:11:46 UTC) #12
Message was sent while issue was closed.
content/browser LGTM.

Powered by Google App Engine
This is Rietveld 408576698