Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 2457883005: Adjust NOT_SHIPPED labels of some README.chromium's (Closed)

Created:
4 years, 1 month ago by Raphael Kubo da Costa (rakuco)
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust NOT_SHIPPED labels of some README.chromium's Commit c11f4b9a ("Mark a few build-time-only third-party README.chromiums as NOT_SHIPPED") switched the "License" field of some projects used only at build-time to "NOT_SHIPPED". However, licenses.py expects NOT_SHIPPED to be set in "License File", which means those projects were still being listed in about:credits. Revert the changes to the "License" field done in that commit and switch "License Files" to NOT_SHIPPED instead. This applies to: - third_party/ijar - third_party/jmake - third_party/markdown (in addition, set "License" to "3 BSD-Clause" to better reflect its nature and to match the Android whitelist in third_party/PRESUBMIT.py). - third_party/ocmock third_party/class-dump was removed in 17ca744 ("Remove old iossim code (pre-Xcode 8) and class-dump") and third_party/proguard was adjusted in 1116f0d ("retrace.jar checked in"). R=agrieve@chromium.org,rockot@chromium.org,rsesek@chromium.org, BUG=332521 Committed: https://crrev.com/71fdc05bd32d94dc5a63845a612fecc33bd8a15f Cr-Commit-Position: refs/heads/master@{#428377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M third_party/ijar/README.chromium View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/jmake/README.chromium View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/markdown/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/ocmock/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Raphael Kubo da Costa (rakuco)
+agrieve for ijar and jmake +rockot for markdown +rsesek for ocmock
4 years, 1 month ago (2016-10-28 13:25:17 UTC) #1
Robert Sesek
ocmock LGTM
4 years, 1 month ago (2016-10-28 13:48:01 UTC) #2
agrieve
On 2016/10/28 13:48:01, Robert Sesek wrote: > ocmock LGTM doh! lgtm Thanks!
4 years, 1 month ago (2016-10-28 14:18:28 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 1 month ago (2016-10-28 14:37:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457883005/1
4 years, 1 month ago (2016-10-28 14:46:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 15:26:47 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 15:49:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71fdc05bd32d94dc5a63845a612fecc33bd8a15f
Cr-Commit-Position: refs/heads/master@{#428377}

Powered by Google App Engine
This is Rietveld 408576698