MD Settings: Misc. Site Settings cleanups.

MD Settings: Misc. Site Settings cleanups.

Removes some dead code. Moves some constants from the header file to
the cc file.

BUG=623587
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/00c78a422a002640e29b2fddd11164f8b46d4a78
Cr-Commit-Position: refs/heads/master@{#428127}

[tommycli, 2016-10-27 18:25:18]

Description was changed from

==========
MD Settings: Misc. Site Settings cleanups.

Removes some dead code. Moves some constants from the header file to
the cc file.

BUG=623587
==========

to

==========
MD Settings: Misc. Site Settings cleanups.

Removes some dead code. Moves some constants from the header file to
the cc file.

BUG=623587
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-10-27 18:25:25]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 18:26:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 18:41:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 18:41:18]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tommycli, 2016-10-27 18:53:57]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 18:54:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-10-27 20:04:31]

tommycli@chromium.org changed reviewers:
+ hcarmona@chromium.org

[tommycli, 2016-10-27 20:04:31]

hcarmona: PTAL, thanks!

[hcarmona, 2016-10-27 20:22:22]

lgtm

[tommycli, 2016-10-27 20:26:46]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2016-10-27 20:26:46]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-10-27 20:26:50]

On 2016/10/27 20:22:22, Hector Carmona wrote:
> lgtm

thanks!

[commit-bot: I haz the power, 2016-10-27 20:27:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 20:33:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-27 20:38:28]

Description was changed from

==========
MD Settings: Misc. Site Settings cleanups.

Removes some dead code. Moves some constants from the header file to
the cc file.

BUG=623587
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Misc. Site Settings cleanups.

Removes some dead code. Moves some constants from the header file to
the cc file.

BUG=623587
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/00c78a422a002640e29b2fddd11164f8b46d4a78
Cr-Commit-Position: refs/heads/master@{#428127}
==========

[commit-bot: I haz the power, 2016-10-27 20:38:29]

Patchset 2 (id:??) landed as
https://crrev.com/00c78a422a002640e29b2fddd11164f8b46d4a78
Cr-Commit-Position: refs/heads/master@{#428127}