Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 245783002: In generated interface header files, #include Handle.h from its new home. (Closed)

Created:
6 years, 8 months ago by sof
Modified:
6 years, 8 months ago
CC:
blink-reviews, Nils Barth (inactive), arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

In generated interface header files, #include Handle.h from its new home. It has moved to platform/heap/Handle.h. R=haraken, nbarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M Source/bindings/scripts/v8_interface.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8SVGTestInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestException.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface2.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface3.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor3.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCustomConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceGarbageCollected.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperations.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look.
6 years, 8 months ago (2014-04-21 20:59:17 UTC) #1
haraken
LGTM
6 years, 8 months ago (2014-04-21 23:34:46 UTC) #2
Nils Barth (inactive)
LGTM2, thanks!
6 years, 8 months ago (2014-04-21 23:37:16 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 8 months ago (2014-04-22 05:06:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/245783002/1
6 years, 8 months ago (2014-04-22 05:06:54 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 05:17:08 UTC) #6
Message was sent while issue was closed. 
Change committed as 172117

Powered by Google App Engine
This is Rietveld 408576698