Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2457783004: Merged: Don't call FastNewFunctionContextStub if context is bigger than kMaxRegularHeapObjectSize. (Closed)

Created:
4 years, 1 month ago by rmcilroy
Modified:
4 years, 1 month ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, oth, v8-merges_googlegroups.com, v8-mips-ports_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.5
Project:
v8
Visibility:
Public.

Description

Merged: Don't call FastNewFunctionContextStub if context is bigger than kMaxRegularHeapObjectSize. Revision: 381b5437b2bf48885f870c7276e2f5cb4e9f8a02 BUG=chromium:655573 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=hablich@chromium.org, hablich Committed: https://chromium.googlesource.com/v8/v8/+/280b6b3ef933c39b76bd6f9af6d438813415ad70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -98 lines) Patch
M src/code-stubs.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +6 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-655573.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmcilroy
4 years, 1 month ago (2016-10-28 10:11:27 UTC) #1
rmcilroy
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years, 1 month ago (2016-10-28 10:11:28 UTC) #2
Michael Hablich
On 2016/10/28 10:11:28, rmcilroy wrote: > NOTE: This script will no longer automatically update include/v8-version.h ...
4 years, 1 month ago (2016-10-28 10:13:57 UTC) #3
rmcilroy
4 years, 1 month ago (2016-10-28 10:17:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
280b6b3ef933c39b76bd6f9af6d438813415ad70.

Powered by Google App Engine
This is Rietveld 408576698