Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2457773002:
[wasm] re-enable wasm serialization post 0xD (Closed)
|
Created:
4 years, 1 month ago by Mircea Trofin Modified:
4 years, 1 month ago CC:
chromium-reviews, blink-reviews, jbroman Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[wasm] re-enable wasm serialization post 0xD
BUG=659591
Committed: https://crrev.com/dea178c3c2b0587d1b6e3cf739b0d97264e31072
Cr-Commit-Position: refs/heads/master@{#428077}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [wasm] re-enable wasm serialization post 0xD BUG=659591 ========== to ========== [wasm] re-enable wasm serialization post 0xD BUG=659591 ==========
mtrofin@chromium.org changed reviewers: + jochen@chromium.org, titzer@chromium.org
Re-enabling since it appears 0xD made it on the chrome side, and since there's work in parallel working on serialization, (Jeremy, cc-ed) and I'd like to ensure we keep coverage for wasm up to avoid regressing.
On 2016/10/27 16:24:47, Mircea Trofin wrote: > Re-enabling since it appears 0xD made it on the chrome side, > and since there's work in parallel working on serialization, > (Jeremy, cc-ed) and I'd like to ensure we keep coverage for > wasm up to avoid regressing. lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mtrofin@chromium.org changed reviewers: + dpranke@chromium.org
+Dirk for local OWNERs list member.
lgtm
The CQ bit was checked by mtrofin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [wasm] re-enable wasm serialization post 0xD BUG=659591 ========== to ========== [wasm] re-enable wasm serialization post 0xD BUG=659591 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [wasm] re-enable wasm serialization post 0xD BUG=659591 ========== to ========== [wasm] re-enable wasm serialization post 0xD BUG=659591 Committed: https://crrev.com/dea178c3c2b0587d1b6e3cf739b0d97264e31072 Cr-Commit-Position: refs/heads/master@{#428077} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/dea178c3c2b0587d1b6e3cf739b0d97264e31072 Cr-Commit-Position: refs/heads/master@{#428077} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
