Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2457723004:
DevTools: do not wait for filesystems to create connection. (Closed)
|
Created:
4 years, 1 month ago by lushnikov Modified:
4 years, 1 month ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: do not wait for filesystems to create connection.
Today, IsolatedFileSystem.create enumerates all the files in the filesystem
before reporting its creation. The front-end is mostly idle during this
process, since most of the time is spent IPC'ing and reading files in the
IO thread.
Before the "Persistence", we were required to wait for the file systems
before creating targets. However, this is not needed anymore, and we can
let people interact with ElementsPanel and other inspection goodness
rightaway.
BUG=660425
R=dgozman, pfeldman
Committed: https://crrev.com/6627d6f8dd0ffc0a3f7b3a0fe709d0d368cc81d0
Cr-Commit-Position: refs/heads/master@{#428594}
Patch Set 1 #
Messages
Total messages: 17 (12 generated)
please, take a look
Description was changed from ========== DevTools: do not wait for filesystems to create connection. Today, IsolatedFileSystem.create reads all the files in the filesystem before reporting its creation. The front-end is mostly idle during this process, since most of the time is spent IPC'ing and reading files in the IO thread. Before the "Persistence", we were required to wait for the file systems before creating targets. However, this is not needed anymore, and we can let people interact with ElementsPanel and other inspection goodness rightaway. BUG=660425 R=dgozman, pfeldman ========== to ========== DevTools: do not wait for filesystems to create connection. Today, IsolatedFileSystem.create enumerates all the files in the filesystem before reporting its creation. The front-end is mostly idle during this process, since most of the time is spent IPC'ing and reading files in the IO thread. Before the "Persistence", we were required to wait for the file systems before creating targets. However, this is not needed anymore, and we can let people interact with ElementsPanel and other inspection goodness rightaway. BUG=660425 R=dgozman, pfeldman ==========
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
lgtm
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DevTools: do not wait for filesystems to create connection. Today, IsolatedFileSystem.create enumerates all the files in the filesystem before reporting its creation. The front-end is mostly idle during this process, since most of the time is spent IPC'ing and reading files in the IO thread. Before the "Persistence", we were required to wait for the file systems before creating targets. However, this is not needed anymore, and we can let people interact with ElementsPanel and other inspection goodness rightaway. BUG=660425 R=dgozman, pfeldman ========== to ========== DevTools: do not wait for filesystems to create connection. Today, IsolatedFileSystem.create enumerates all the files in the filesystem before reporting its creation. The front-end is mostly idle during this process, since most of the time is spent IPC'ing and reading files in the IO thread. Before the "Persistence", we were required to wait for the file systems before creating targets. However, this is not needed anymore, and we can let people interact with ElementsPanel and other inspection goodness rightaway. BUG=660425 R=dgozman, pfeldman ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== DevTools: do not wait for filesystems to create connection. Today, IsolatedFileSystem.create enumerates all the files in the filesystem before reporting its creation. The front-end is mostly idle during this process, since most of the time is spent IPC'ing and reading files in the IO thread. Before the "Persistence", we were required to wait for the file systems before creating targets. However, this is not needed anymore, and we can let people interact with ElementsPanel and other inspection goodness rightaway. BUG=660425 R=dgozman, pfeldman ========== to ========== DevTools: do not wait for filesystems to create connection. Today, IsolatedFileSystem.create enumerates all the files in the filesystem before reporting its creation. The front-end is mostly idle during this process, since most of the time is spent IPC'ing and reading files in the IO thread. Before the "Persistence", we were required to wait for the file systems before creating targets. However, this is not needed anymore, and we can let people interact with ElementsPanel and other inspection goodness rightaway. BUG=660425 R=dgozman, pfeldman Committed: https://crrev.com/6627d6f8dd0ffc0a3f7b3a0fe709d0d368cc81d0 Cr-Commit-Position: refs/heads/master@{#428594} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6627d6f8dd0ffc0a3f7b3a0fe709d0d368cc81d0 Cr-Commit-Position: refs/heads/master@{#428594} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
