Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 2457703006: Sign-in promo in the password bubble: test dismissal_threshold=3 on the waterfall. (Closed)

Created:
4 years, 1 month ago by vasilii
Modified:
4 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sign-in promo in the password bubble: test dismissal_threshold=3 on the waterfall. BUG=615825 Committed: https://crrev.com/b63ccca158a9891abef94629ae04f3e34148e17f Cr-Commit-Position: refs/heads/master@{#428438}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
vasilii
Hi Ilya, please review.
4 years, 1 month ago (2016-10-28 15:03:50 UTC) #4
Ilya Sherman
lgtm
4 years, 1 month ago (2016-10-28 18:31:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457703006/1
4 years, 1 month ago (2016-10-28 18:32:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 18:40:49 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 19:08:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b63ccca158a9891abef94629ae04f3e34148e17f
Cr-Commit-Position: refs/heads/master@{#428438}

Powered by Google App Engine
This is Rietveld 408576698