Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2457703003: Update build.gni to match chromium/src/build (Closed)

Created:
4 years, 1 month ago by Sam Clegg
Modified:
4 years, 1 month ago
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update build.gni to match chromium/src/build This is necessary to allow DEPS updates to get the new build/ from chromium/src/build/. R=bradnelson@chromium.org, mcgrathr@chromium.org BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4381 Committed: https://chromium.googlesource.com/native_client/src/build_overrides/+/736dde6d656d80706dc0346c8ae049217961bed1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M build.gni View 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sam Clegg
4 years, 1 month ago (2016-10-28 00:51:56 UTC) #1
bradnelson
lgtm
4 years, 1 month ago (2016-10-28 14:37:43 UTC) #2
Sam Clegg
4 years, 1 month ago (2016-10-28 16:17:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
736dde6d656d80706dc0346c8ae049217961bed1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698