Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2457693002: Revert of Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image (Closed)

Created:
4 years, 1 month ago by foolip
Modified:
4 years, 1 month ago
Reviewers:
Ian Wen, wychen
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image (patchset #1 id:1 of https://codereview.chromium.org/2451883002/ ) Reason for revert: Failures in chrome_public_test_apk on Android Tests (dbg) including failures in CustomTabActivityTest traced to this CL by findit. Original issue's description: > Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image > > TBR=yusufo@chromium.org > BUG=655970 > > Committed: https://crrev.com/ca6324d8474f7b2e23b21c78b7bf4e6f390757d6 > Cr-Commit-Position: refs/heads/master@{#427899} TBR=ianwen@chromium.org,wychen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=655970 Committed: https://crrev.com/1bc6bfeed1918d135ff8ed06b8f2bf0642abcc12 Cr-Commit-Position: refs/heads/master@{#427971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 3 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
foolip
Created Revert of Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image
4 years, 1 month ago (2016-10-27 08:56:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457693002/1
4 years, 1 month ago (2016-10-27 08:57:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 08:59:03 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1bc6bfeed1918d135ff8ed06b8f2bf0642abcc12 Cr-Commit-Position: refs/heads/master@{#427971}
4 years, 1 month ago (2016-10-27 09:03:27 UTC) #7
wychen
4 years, 1 month ago (2016-10-28 00:56:42 UTC) #8
Message was sent while issue was closed.
I think the result returned by findit was not accurate due to flaky tests.

The build returned to normal before the revert.
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Test...

I'll land it again as is and hopefully sticks this time.

Powered by Google App Engine
This is Rietveld 408576698