xfa/fxfa/app/xfa_ffwidgethandler.cpp - Issue 2457673003: Fix some FX_BOOL / int noise in fxfa

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_ffwidgethandler.cpp

Issue 2457673003: Fix some FX_BOOL / int noise in fxfa (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/app/xfa_ffwidgethandler.cpp

diff --git a/xfa/fxfa/app/xfa_ffwidgethandler.cpp b/xfa/fxfa/app/xfa_ffwidgethandler.cpp

index 3df2d2a473ef6606e8713b533967a4a857a3c481..854b1ac384d424cbb15f90b0b23fc14959434158 100644

--- a/xfa/fxfa/app/xfa_ffwidgethandler.cpp

+++ b/xfa/fxfa/app/xfa_ffwidgethandler.cpp

@@ -211,7 +211,7 @@ FX_BOOL CXFA_FFWidgetHandler::HasEvent(CXFA_WidgetAcc* pWidgetAcc,

}

CXFA_NodeArray eventArray;

return pWidgetAcc->GetEventByActivity(gs_EventActivity[eEventType],

Tom Sepez 2016/10/27 21:04:49 Returns a count of events. Probably should be uns

Lei Zhang 2016/10/27 21:28:52 Yes, many many things need to be unsigned...

- eventArray);

+ eventArray) > 0;

}

int32_t CXFA_FFWidgetHandler::ProcessEvent(CXFA_WidgetAcc* pWidgetAcc,