Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: xfa/fxfa/app/xfa_ffwidgethandler.cpp

Issue 2457673003: Fix some FX_BOOL / int noise in fxfa (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fxfa/xfa_ffwidgethandler.h" 7 #include "xfa/fxfa/xfa_ffwidgethandler.h"
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 if (!val) 203 if (!val)
204 return FALSE; 204 return FALSE;
205 if (val.GetScript()) 205 if (val.GetScript())
206 return TRUE; 206 return TRUE;
207 return FALSE; 207 return FALSE;
208 } 208 }
209 default: 209 default:
210 break; 210 break;
211 } 211 }
212 CXFA_NodeArray eventArray; 212 CXFA_NodeArray eventArray;
213 return pWidgetAcc->GetEventByActivity(gs_EventActivity[eEventType], 213 return pWidgetAcc->GetEventByActivity(gs_EventActivity[eEventType],
Tom Sepez 2016/10/27 21:04:49 Returns a count of events. Probably should be uns
Lei Zhang 2016/10/27 21:28:52 Yes, many many things need to be unsigned...
214 eventArray); 214 eventArray) > 0;
215 } 215 }
216 216
217 int32_t CXFA_FFWidgetHandler::ProcessEvent(CXFA_WidgetAcc* pWidgetAcc, 217 int32_t CXFA_FFWidgetHandler::ProcessEvent(CXFA_WidgetAcc* pWidgetAcc,
218 CXFA_EventParam* pParam) { 218 CXFA_EventParam* pParam) {
219 if (!pParam || pParam->m_eType == XFA_EVENT_Unknown) 219 if (!pParam || pParam->m_eType == XFA_EVENT_Unknown)
220 return XFA_EVENTERROR_NotExist; 220 return XFA_EVENTERROR_NotExist;
221 if (!pWidgetAcc || pWidgetAcc->GetElementType() == XFA_Element::Draw) 221 if (!pWidgetAcc || pWidgetAcc->GetElementType() == XFA_Element::Draw)
222 return XFA_EVENTERROR_NotExist; 222 return XFA_EVENTERROR_NotExist;
223 223
224 switch (pParam->m_eType) { 224 switch (pParam->m_eType) {
(...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after
544 } 544 }
545 545
546 CXFA_Document* CXFA_FFWidgetHandler::GetObjFactory() const { 546 CXFA_Document* CXFA_FFWidgetHandler::GetObjFactory() const {
547 return GetXFADoc(); 547 return GetXFADoc();
548 } 548 }
549 549
550 CXFA_Document* CXFA_FFWidgetHandler::GetXFADoc() const { 550 CXFA_Document* CXFA_FFWidgetHandler::GetXFADoc() const {
551 return m_pDocView->GetDoc()->GetXFADoc(); 551 return m_pDocView->GetDoc()->GetXFADoc();
552 } 552 }
553 553
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698