Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1729)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java

Issue 2457663002: Merge WebappInfo and WebApkMetaData part 1/2 (Closed)
Patch Set: Merge branch 'master' into update_fail_refactor00 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java
index b4843642c2a072437f300c8b44995a190ef007b6..b1c12d8e7c5b18bdbce1cbdca400adbe6930b4cd 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java
@@ -13,7 +13,6 @@ import org.chromium.blink_public.platform.WebDisplayMode;
import org.chromium.chrome.browser.ShortcutHelper;
import org.chromium.chrome.browser.ShortcutSource;
import org.chromium.content_public.common.ScreenOrientationValues;
-import org.chromium.webapk.lib.common.WebApkConstants;
/**
* Tests the WebappInfo class's ability to parse various URLs.
@@ -30,7 +29,7 @@ public class WebappInfoTest extends InstrumentationTestCase {
WebappInfo info = WebappInfo.create(id, url, null, null, name, shortName,
WebDisplayMode.Standalone, ScreenOrientationValues.DEFAULT, ShortcutSource.UNKNOWN,
ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING,
- ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING, false, null);
+ ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING, false);
assertNotNull(info);
}
@@ -45,7 +44,7 @@ public class WebappInfoTest extends InstrumentationTestCase {
WebappInfo info = WebappInfo.create(id, url, null, null, name, shortName,
WebDisplayMode.Standalone, ScreenOrientationValues.DEFAULT, ShortcutSource.UNKNOWN,
ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING,
- ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING, false, null);
+ ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING, false);
assertNotNull(info);
}
@@ -134,7 +133,7 @@ public class WebappInfoTest extends InstrumentationTestCase {
WebappInfo info = WebappInfo.create(id, url, null, null, name, shortName,
WebDisplayMode.Fullscreen, ScreenOrientationValues.DEFAULT, ShortcutSource.UNKNOWN,
ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING,
- ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING, false, null);
+ ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING, false);
assertEquals(WebDisplayMode.Fullscreen, info.displayMode());
assertEquals(ScreenOrientationValues.DEFAULT, info.orientation());
assertEquals(ShortcutSource.UNKNOWN, info.source());
@@ -152,7 +151,7 @@ public class WebappInfoTest extends InstrumentationTestCase {
WebappInfo info = WebappInfo.create(id, url, null, null, name, shortName,
WebDisplayMode.Standalone, ScreenOrientationValues.DEFAULT,
- ShortcutSource.UNKNOWN, themeColor, backgroundColor, false, null);
+ ShortcutSource.UNKNOWN, themeColor, backgroundColor, false);
assertEquals(themeColor, info.themeColor());
assertEquals(backgroundColor, info.backgroundColor());
}
@@ -168,7 +167,7 @@ public class WebappInfoTest extends InstrumentationTestCase {
WebappInfo info = WebappInfo.create(id, url, null, null, name, shortName,
WebDisplayMode.Standalone, ScreenOrientationValues.DEFAULT, ShortcutSource.UNKNOWN,
ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING,
- ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING, false, null);
+ ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING, false);
assertEquals(ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING, info.themeColor());
assertEquals(ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING, info.backgroundColor());
}
@@ -189,7 +188,7 @@ public class WebappInfoTest extends InstrumentationTestCase {
}
@SmallTest
- @Feature({"Webapps", "WebApk"})
+ @Feature({"Webapps"})
public void testScopeIntentCreation() {
String scope = "https://www.foo.com";
Intent intent = createIntentWithUrlAndId();
@@ -199,7 +198,7 @@ public class WebappInfoTest extends InstrumentationTestCase {
}
@SmallTest
- @Feature({"Webapps", "WebApk"})
+ @Feature({"Webapps"})
public void testIntentScopeFallback() {
String url = "https://www.foo.com/homepage.html";
Intent intent = createIntentWithUrlAndId();
@@ -209,7 +208,7 @@ public class WebappInfoTest extends InstrumentationTestCase {
}
@SmallTest
- @Feature({"Webapps", "WebApk"})
+ @Feature({"Webapps"})
public void testIntentDisplayMode() {
Intent intent = createIntentWithUrlAndId();
intent.putExtra(ShortcutHelper.EXTRA_DISPLAY_MODE, WebDisplayMode.MinimalUi);
@@ -218,7 +217,7 @@ public class WebappInfoTest extends InstrumentationTestCase {
}
@SmallTest
- @Feature({"Webapps", "WebApk"})
+ @Feature({"Webapps"})
public void testIntentOrientation() {
Intent intent = createIntentWithUrlAndId();
intent.putExtra(ShortcutHelper.EXTRA_ORIENTATION, ScreenOrientationValues.LANDSCAPE);
@@ -282,18 +281,6 @@ public class WebappInfoTest extends InstrumentationTestCase {
}
}
- @SmallTest
- @Feature({"WebApk"})
- public void testIntentWebApkPackageName() {
- String packageName = WebApkConstants.WEBAPK_PACKAGE_PREFIX + ".foo";
-
- Intent intent = createIntentWithUrlAndId();
- intent.putExtra(ShortcutHelper.EXTRA_WEBAPK_PACKAGE_NAME, packageName);
-
- WebappInfo info = WebappInfo.create(intent);
- assertEquals(packageName, info.webApkPackageName());
- }
-
/**
* Creates intent with url and id. If the url or id are not set WebappInfo#create() returns
* null.
« no previous file with comments | « chrome/android/java_sources.gni ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698