Add UseCounter for WebBluetooth

Add UseCounter for WebBluetooth

This CL adds UseCounter for WebBluetooth's requestDevice() function. It
can help us know how often the WebBluetooth feature is used on web pages.

BUG=660309
Committed: https://crrev.com/6e569bd13f93845119ff051a6050888a65df16c7
Cr-Commit-Position: refs/heads/master@{#428898}

[juncai, 2016-10-28 18:22:38]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 18:23:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-10-28 18:24:06]

juncai@chromium.org changed reviewers:
+ scheib@chromium.org

[juncai, 2016-10-28 18:24:07]

Please take a look.

[commit-bot: I haz the power, 2016-10-28 21:35:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 21:35:39]

Dry run: This issue passed the CQ dry run.

[scheib, 2016-10-28 23:20:35]

https://codereview.chromium.org/2457653004/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp (right):

https://codereview.chromium.org/2457653004/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp:180:
UseCounter::count(context, UseCounter::WebBluetoothRequestDevice);
Instead of using this here, use IDL MeasureAs extended attribute:

https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/So...

[juncai, 2016-10-28 23:48:50]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 23:49:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-10-28 23:49:45]

https://codereview.chromium.org/2457653004/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp (right):

https://codereview.chromium.org/2457653004/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp:180:
UseCounter::count(context, UseCounter::WebBluetoothRequestDevice);
On 2016/10/28 23:20:35, scheib wrote:
> Instead of using this here, use IDL MeasureAs extended attribute:
> 
>
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/So...
> 

Done.

[juncai, 2016-10-29 00:50:23]

juncai@chromium.org changed reviewers:
+ dcheng@chromium.org

[juncai, 2016-10-29 00:50:23]

dcheng@chromium.org: Please review changes in 
//third_party/WebKit/Source/core/frame/UseCounter.h

[dcheng, 2016-10-29 01:22:40]

UseCounter.h lgtm

[haraken, 2016-10-29 01:25:43]

histograms LGTM

[commit-bot: I haz the power, 2016-10-29 01:26:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-29 01:26:27]

Dry run: This issue passed the CQ dry run.

[ortuno, 2016-10-31 04:41:41]

ortuno@chromium.org changed reviewers:
+ haraken@chromium.org, ortuno@chromium.org

[ortuno, 2016-10-31 04:41:41]

bluetooth lgm

[ortuno, 2016-10-31 04:42:00]

drive-by bluetooth lgtm for realz

[scheib, 2016-10-31 18:46:03]

LGTM

[juncai, 2016-10-31 19:23:28]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2016-10-31 19:24:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 21:21:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 21:21:46]

Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/core/frame/UseCounter.h:1388
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/core/frame/UseCounter.h' with
conflicts.
  U third_party/WebKit/Source/core/frame/UseCounter.h

Patch:       third_party/WebKit/Source/core/frame/UseCounter.h
Index: third_party/WebKit/Source/core/frame/UseCounter.h
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.h
b/third_party/WebKit/Source/core/frame/UseCounter.h
index
4baee8532b2b565d08103f17c4262dcb8532f674..9315ed3fa9a0b4a8e39767fc40551bbb185c5bc2
100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.h
+++ b/third_party/WebKit/Source/core/frame/UseCounter.h
@@ -1388,6 +1388,7 @@ class CORE_EXPORT UseCounter {
     ScriptWithCSPBypassingSchemeParserInserted = 1666,
     ScriptWithCSPBypassingSchemeNotParserInserted = 1667,
     DocumentCreateElement2ndArgStringHandling = 1668,
+    WebBluetoothRequestDevice = 1669,
 
     // Add new features immediately above this line. Don't change assigned
     // numbers of any item, and don't reuse removed slots.

[juncai, 2016-10-31 21:36:16]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 21:37:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 01:10:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 01:10:17]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-11-01 01:14:03]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-11-01 01:14:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, scheib@chromium.org, ortuno@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2457653004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-01 01:14:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 01:20:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-01 01:23:38]

Description was changed from

==========
Add UseCounter for WebBluetooth

This CL adds UseCounter for WebBluetooth's requestDevice() function. It
can help us know how often the WebBluetooth feature is used on web pages.

BUG=660309
==========

to

==========
Add UseCounter for WebBluetooth

This CL adds UseCounter for WebBluetooth's requestDevice() function. It
can help us know how often the WebBluetooth feature is used on web pages.

BUG=660309

Committed: https://crrev.com/6e569bd13f93845119ff051a6050888a65df16c7
Cr-Commit-Position: refs/heads/master@{#428898}
==========

[commit-bot: I haz the power, 2016-11-01 01:23:39]

Patchset 3 (id:??) landed as
https://crrev.com/6e569bd13f93845119ff051a6050888a65df16c7
Cr-Commit-Position: refs/heads/master@{#428898}