Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: chrome/browser/ui/startup/startup_tab_provider_unittest.cc

Issue 2457653003: Completing refactor of startup_browser_creator_impl (Closed)
Patch Set: Addressing pkasting comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/startup/startup_tab_provider.cc ('k') | chrome/common/chrome_switches.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/startup/startup_tab_provider_unittest.cc
diff --git a/chrome/browser/ui/startup/startup_tab_provider_unittest.cc b/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
index 3cc644aefadfd68afbd95b16be314337e2831c99..fd0e06108f47ace1621f482c95c06648551f376b 100644
--- a/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
+++ b/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
@@ -68,6 +68,33 @@ TEST(StartupTabProviderTest, CheckResetTriggerTabPolicy_Negative) {
ASSERT_TRUE(output.empty());
}
+TEST(StartupTabProviderTest, CheckPinnedTabPolicy) {
+ StartupTabs pinned = {StartupTab(GURL("https://www.google.com"), true)};
+ SessionStartupPref pref_default(SessionStartupPref::Type::DEFAULT);
+ SessionStartupPref pref_urls(SessionStartupPref::Type::URLS);
+
+ StartupTabs output =
+ StartupTabProviderImpl::CheckPinnedTabPolicy(pref_default, pinned);
+
+ ASSERT_EQ(1U, output.size());
+ EXPECT_EQ("www.google.com", output[0].url.host());
+
+ output = StartupTabProviderImpl::CheckPinnedTabPolicy(pref_urls, pinned);
+
+ ASSERT_EQ(1U, output.size());
+ EXPECT_EQ("www.google.com", output[0].url.host());
+}
+
+TEST(StartupTabProviderTest, CheckPinnedTabPolicy_Negative) {
+ StartupTabs pinned = {StartupTab(GURL("https://www.google.com"), true)};
+ SessionStartupPref pref_last(SessionStartupPref::Type::LAST);
+
+ StartupTabs output =
+ StartupTabProviderImpl::CheckPinnedTabPolicy(pref_last, pinned);
+
+ ASSERT_TRUE(output.empty());
+}
+
TEST(StartupTabProviderTest, CheckPreferencesTabPolicy) {
SessionStartupPref pref(SessionStartupPref::Type::URLS);
pref.urls = {GURL(base::ASCIIToUTF16("https://www.google.com"))};
@@ -94,3 +121,28 @@ TEST(StartupTabProviderTest, CheckPreferencesTabPolicy_Negative) {
EXPECT_TRUE(output.empty());
}
+
+TEST(StartupTabProviderTest, CheckNewTabPageTabPolicy) {
+ SessionStartupPref pref_default(SessionStartupPref::Type::DEFAULT);
+ SessionStartupPref pref_urls(SessionStartupPref::Type::URLS);
+
+ StartupTabs output =
+ StartupTabProviderImpl::CheckNewTabPageTabPolicy(pref_default);
+
+ ASSERT_EQ(1U, output.size());
+ EXPECT_EQ(GURL(chrome::kChromeUINewTabURL), output[0].url);
+
+ output = StartupTabProviderImpl::CheckNewTabPageTabPolicy(pref_urls);
+
+ ASSERT_EQ(1U, output.size());
+ EXPECT_EQ(GURL(chrome::kChromeUINewTabURL), output[0].url);
+}
+
+TEST(StartupTabProviderTest, CheckNewTabPageTabPolicy_Negative) {
+ SessionStartupPref pref_last(SessionStartupPref::Type::LAST);
+
+ StartupTabs output =
+ StartupTabProviderImpl::CheckNewTabPageTabPolicy(pref_last);
+
+ ASSERT_TRUE(output.empty());
+}
« no previous file with comments | « chrome/browser/ui/startup/startup_tab_provider.cc ('k') | chrome/common/chrome_switches.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698