Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2457643002: [MD settings] site data details subpage title (Closed)

Created:
4 years, 1 month ago by dschuyler
Modified:
4 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] site data details subpage title This CL changes the title of the cookies data details subpage to add a note about it being local data. BUG=654943 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/cd2b8502f06ffc672fe4465a8d2863b4dd38108d Cr-Commit-Position: refs/heads/master@{#429459}

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/app/settings_strings.grdp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data_details_subpage.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (17 generated)
dschuyler
4 years, 1 month ago (2016-10-27 21:33:50 UTC) #9
Dan Beam
lgtm
4 years, 1 month ago (2016-10-27 23:33:30 UTC) #12
dschuyler
merged with master
4 years, 1 month ago (2016-11-02 22:08:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457643002/40001
4 years, 1 month ago (2016-11-02 23:40:12 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-02 23:45:47 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 23:49:33 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cd2b8502f06ffc672fe4465a8d2863b4dd38108d
Cr-Commit-Position: refs/heads/master@{#429459}

Powered by Google App Engine
This is Rietveld 408576698