Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Issue 2457623003: Add comment about wrong policy merging (Closed)

Created:
4 years, 1 month ago by ljusten (tachyonic)
Modified:
4 years, 1 month ago
Reviewers:
pastarmovj
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add comment about wrong policy merging BUG=659979 Committed: https://crrev.com/f557ade7166e9b2399c84f6077dc47a4167c5b19 Cr-Commit-Position: refs/heads/master@{#428009}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add bug number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M components/policy/core/common/policy_loader_win.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
ljusten (tachyonic)
Added the comments as discussed.
4 years, 1 month ago (2016-10-27 11:46:16 UTC) #2
pastarmovj
lgtm with a nit. https://codereview.chromium.org/2457623003/diff/1/components/policy/core/common/policy_loader_win.cc File components/policy/core/common/policy_loader_win.cc (right): https://codereview.chromium.org/2457623003/diff/1/components/policy/core/common/policy_loader_win.cc#newcode496 components/policy/core/common/policy_loader_win.cc:496: // last). nit: Please extract ...
4 years, 1 month ago (2016-10-27 11:47:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457623003/1
4 years, 1 month ago (2016-10-27 12:08:39 UTC) #6
ljusten (tachyonic)
4 years, 1 month ago (2016-10-27 12:12:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457623003/20001
4 years, 1 month ago (2016-10-27 12:17:29 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 13:15:26 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 13:19:00 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f557ade7166e9b2399c84f6077dc47a4167c5b19
Cr-Commit-Position: refs/heads/master@{#428009}

Powered by Google App Engine
This is Rietveld 408576698