third_party/WebKit/Source/core/editing/DOMSelection.cpp - Issue 2457613004: Utilize FrameSelection::setSelection() taking SelectionInDOMTree/SelectionInFlatTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/DOMSelection.cpp

Issue 2457613004: Utilize FrameSelection::setSelection() taking SelectionInDOMTree/SelectionInFlatTree (Closed)

Patch Set: 2016-10-28T15:45:56 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/DOMSelection.cpp

diff --git a/third_party/WebKit/Source/core/editing/DOMSelection.cpp b/third_party/WebKit/Source/core/editing/DOMSelection.cpp

index 0a1501f0ffea6ca18800ee7703434d1d08b6bad4..69d3e5a55c463fbb83e19d4a78649e1d014e4bc9 100644

--- a/third_party/WebKit/Source/core/editing/DOMSelection.cpp

+++ b/third_party/WebKit/Source/core/editing/DOMSelection.cpp

@@ -231,7 +231,7 @@ void DOMSelection::collapseToEnd(ExceptionState& exceptionState) {

SelectionInDOMTree::Builder builder;

builder.collapse(selection.end());

- frame()->selection().setSelection(createVisibleSelection(builder.build()));

+ frame()->selection().setSelection(builder.build());

}

void DOMSelection::collapseToStart(ExceptionState& exceptionState) {

@@ -255,7 +255,7 @@ void DOMSelection::collapseToStart(ExceptionState& exceptionState) {

SelectionInDOMTree::Builder builder;

builder.collapse(selection.start());

- frame()->selection().setSelection(createVisibleSelection(builder.build()));

+ frame()->selection().setSelection(builder.build());

}

void DOMSelection::empty() {

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »