Utilize FrameSelection::setSelection() taking SelectionInDOMTree/SelectionInFlatTree

Utilize FrameSelection::setSelection() taking SelectionInDOMTree/SelectionInFlatTree

This patch changes |FrameSelection:setSelection()| taking |VisibleSelection| and
|VisibleSelectionInFlatTRee| to use |SelectionIn{DOM,Flat}Tree| to reduce
usage of |VisibleSelection{,InFlatTree}| for improving code health.

BUG=657237
TEST=n/a; no behavior changes

Committed: https://crrev.com/1ab21eb247b8c05daf26de66bfb63a323c738866
Committed: https://crrev.com/31a4628dfd8c8633077d89d9abb34638547ad699
Cr-Original-Commit-Position: refs/heads/master@{#428660}
Cr-Commit-Position: refs/heads/master@{#434447}

[yosin_UTC9, 2016-10-28 06:10:53]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 06:11:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 06:21:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 06:21:58]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2016-10-28 06:46:41]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 06:46:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 08:06:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 08:06:59]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-10-28 09:50:25]

Description was changed from

==========
2016-10-28T15:08:31

BUG=
==========

to

==========
Utilize FrameSelection::setSelection() taking
SelectionInDOMTree/SelectionInFlatTree

This patch changes |FrameSelection:setSelection()| taking |VisibleSelection| and
|VisibleSelectionInFlatTRee| to use |SelectionIn{DOM,Flat}Tree| to reduce
usage of |VisibleSelection{,InFlatTree}| for improving code health.

BUG=657237
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-10-28 09:50:36]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-10-28 09:50:36]

PTAL

[Xiaocheng, 2016-10-28 10:09:43]

https://codereview.chromium.org/2457613004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2457613004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:230:
frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
We can remove this call now.

https://codereview.chromium.org/2457613004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:254:
frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
We can remove this call now.

[yosin_UTC9, 2016-10-31 04:45:38]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 04:45:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 06:03:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 06:03:54]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-10-31 06:13:08]

PTAL

Get rid of redundant updateStyleAndLayoutI... as suggested

https://codereview.chromium.org/2457613004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2457613004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:230:
frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
On 2016/10/28 at 10:09:43, Xiaocheng wrote:
> We can remove this call now.

Done.

https://codereview.chromium.org/2457613004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:254:
frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
On 2016/10/28 at 10:09:43, Xiaocheng wrote:
> We can remove this call now.

Done

[Xiaocheng, 2016-10-31 06:18:41]

lgtm

[yosin_UTC9, 2016-10-31 06:25:00]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-10-31 06:25:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 06:28:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-31 06:30:18]

Description was changed from

==========
Utilize FrameSelection::setSelection() taking
SelectionInDOMTree/SelectionInFlatTree

This patch changes |FrameSelection:setSelection()| taking |VisibleSelection| and
|VisibleSelectionInFlatTRee| to use |SelectionIn{DOM,Flat}Tree| to reduce
usage of |VisibleSelection{,InFlatTree}| for improving code health.

BUG=657237
TEST=n/a; no behavior changes
==========

to

==========
Utilize FrameSelection::setSelection() taking
SelectionInDOMTree/SelectionInFlatTree

This patch changes |FrameSelection:setSelection()| taking |VisibleSelection| and
|VisibleSelectionInFlatTRee| to use |SelectionIn{DOM,Flat}Tree| to reduce
usage of |VisibleSelection{,InFlatTree}| for improving code health.

BUG=657237
TEST=n/a; no behavior changes

Committed: https://crrev.com/1ab21eb247b8c05daf26de66bfb63a323c738866
Cr-Commit-Position: refs/heads/master@{#428660}
==========

[commit-bot: I haz the power, 2016-10-31 06:30:19]

Patchset 3 (id:??) landed as
https://crrev.com/1ab21eb247b8c05daf26de66bfb63a323c738866
Cr-Commit-Position: refs/heads/master@{#428660}

[aelias_OOO_until_Jul13, 2016-11-10 20:04:57]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2491763004/ by aelias@chromium.org.

The reason for reverting is: Caused http://b/32727536.

[yosin_UTC9, 2016-11-24 03:40:12]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-11-24 03:40:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 03:43:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 03:43:10]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[yosin_UTC9, 2016-11-24 04:05:00]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-11-24 04:05:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2457613004/#ps60001
(title: "2016-11-24T13:04:01 Rebase")

[commit-bot: I haz the power, 2016-11-24 04:05:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 06:06:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 06:06:41]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[yosin_UTC9, 2016-11-24 13:58:05]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-11-24 13:58:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 15:23:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 15:23:28]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2016-11-25 01:17:27]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-11-25 01:17:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 02:00:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 02:00:08]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2016-11-25 02:00:36]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-11-25 02:00:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 02:44:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 02:44:39]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2016-11-25 04:03:10]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-11-25 04:03:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 06:27:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 06:27:44]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yosin_UTC9, 2016-11-25 06:32:25]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-11-25 06:32:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 07:44:48]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480055545304300,
"parent_rev": "4f693ab5902d0f93010ce02b76dcb869060c48b6", "commit_rev":
"723fa14ae40d44a601f480b20fbc6374b69cc62b"}

[commit-bot: I haz the power, 2016-11-25 07:45:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-25 07:47:19]

Description was changed from

==========
Utilize FrameSelection::setSelection() taking
SelectionInDOMTree/SelectionInFlatTree

This patch changes |FrameSelection:setSelection()| taking |VisibleSelection| and
|VisibleSelectionInFlatTRee| to use |SelectionIn{DOM,Flat}Tree| to reduce
usage of |VisibleSelection{,InFlatTree}| for improving code health.

BUG=657237
TEST=n/a; no behavior changes

Committed: https://crrev.com/1ab21eb247b8c05daf26de66bfb63a323c738866
Cr-Commit-Position: refs/heads/master@{#428660}
==========

to

==========
Utilize FrameSelection::setSelection() taking
SelectionInDOMTree/SelectionInFlatTree

This patch changes |FrameSelection:setSelection()| taking |VisibleSelection| and
|VisibleSelectionInFlatTRee| to use |SelectionIn{DOM,Flat}Tree| to reduce
usage of |VisibleSelection{,InFlatTree}| for improving code health.

BUG=657237
TEST=n/a; no behavior changes

Committed: https://crrev.com/1ab21eb247b8c05daf26de66bfb63a323c738866
Committed: https://crrev.com/31a4628dfd8c8633077d89d9abb34638547ad699
Cr-Original-Commit-Position: refs/heads/master@{#428660}
Cr-Commit-Position: refs/heads/master@{#434447}
==========

[commit-bot: I haz the power, 2016-11-25 07:47:20]

Patchset 4 (id:??) landed as
https://crrev.com/31a4628dfd8c8633077d89d9abb34638547ad699
Cr-Commit-Position: refs/heads/master@{#434447}