<webview>: Change how plugin load works inside guests.

chrome/renderer/resources/extensions/web_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Shim that simulates a <webview> tag via Mutation Observers.
 //
 // The actual tag is implemented via the browser plugin. The internals of this
 // are hidden via Shadow DOM.
 
 'use strict';
@@ skipping 93 matching lines @@
       'name'
     ]
   },
   'permissionrequest': {
     cancelable: true,
     customHandler: function(webViewInternal, event, webViewEvent) {
       webViewInternal.handlePermissionEvent_(event, webViewEvent);
     },
     evt: CreateEvent('webview.onPermissionRequest'),
     fields: [
+      'identifier',
       'lastUnlockedBySelf',
+      'name',
       'permission',
       'requestMethod',
       'url',
       'userGesture'
     ]
   },
   'responsive': {
     evt: CreateEvent('webview.onResponsive'),
     fields: ['processId']
   },
@@ skipping 619 matching lines @@
     function(event, webViewEvent) {
   var ERROR_MSG_PERMISSION_ALREADY_DECIDED = '<webview>: ' +
       'Permission has already been decided for this "permissionrequest" event.';
 
   var showWarningMessage = function(permission) {
     var WARNING_MSG_PERMISSION_DENIED = '<webview>: ' +
         'The permission request for "%1" has been denied.';
     console.warn(WARNING_MSG_PERMISSION_DENIED.replace('%1', permission));
   };
 
-  var PERMISSION_TYPES = this.getPermissionTypes_();
+  var PERMISSION_TYPES = this.getPermissionTypes_().concat(
+                             this.maybeGetExperimentalPermissions_());
+  if (PERMISSION_TYPES.indexOf(event.permission) < 0) {
+    // The permission type is not allowed. Trigger the default response.
+    var defaultPermission = this.getDefaultPermission_(event);
+    WebView.setPermission(self.instanceId_, requestId, defaultPermission, '');
+    if (!defaultPermission)
+      showWarningMessage(event.permission);
+    return;
+  }
 
   var self = this;
   var browserPluginNode = this.browserPluginNode_;
   var webviewNode = this.webviewNode_;
 
   var requestId = event.requestId;
   var decisionMade = false;
 
   var validateCall = function() {
     if (decisionMade) {
@@ skipping 13 matching lines @@
       WebView.setPermission(self.instanceId_, requestId, false, '');
     }
   };
   webViewEvent.request = request;
 
   var defaultPrevented = !webviewNode.dispatchEvent(webViewEvent);
   if (decisionMade) {
     return;
   }
 
+  var defaultPermission = this.getDefaultPermission_(event);
   if (defaultPrevented) {
     // Make browser plugin track lifetime of |request|.
     MessagingNatives.BindToGC(request, function() {
       // Avoid showing a warning message if the decision has already been made.
       if (decisionMade) {
         return;
       }
-      WebView.setPermission(self.instanceId_, requestId, false, '');
-      showWarningMessage(event.permission);
+      WebView.setPermission(self.instanceId_, requestId, defaultPermission, '');
+      if (!defaultPermission)
+        showWarningMessage(event.permission);
     });
   } else {
     decisionMade = true;
-    WebView.setPermission(self.instanceId_, requestId, false, '');
-    showWarningMessage(event.permission);
+    WebView.setPermission(self.instanceId_, requestId, defaultPermission, '');
+    if (!defaultPermission)
+      showWarningMessage(event.permission);
   }
 };
 
 /**
  * @private
  */
 WebViewInternal.prototype.setupWebRequestEvents_ = function() {
   var self = this;
   var request = {};
   var createWebRequestEvent = function(webRequestEvent) {
@@ skipping 150 matching lines @@
  * @private
  */
 WebViewInternal.prototype.maybeGetExperimentalEvents_ = function() {};
 
 /**
  * Implemented when the experimental API is available.
  * @private
  */
 WebViewInternal.prototype.maybeAttachWebRequestEventToWebview_ = function() {};
 
+/**
+ * Implemented when the experimental API is available.
+ * @private
+ */
+WebViewInternal.prototype.maybeGetExperimentalPermissions_ = function() {
+  return [];
+};
+
+/** @private */
+WebViewInternal.prototype.getDefaultPermission_ = function(event) {
+  var PERMISSIONS_DEFAULT_ALLOWED = ['loadplugin'];

[Fady Samuel, 2013/09/26 21:27:12]

For consistency, could you call to web_view_experimental here for loadplugin?

[sadrul, 2013/09/26 21:51:33]

We discussed offline. This is necessary here to make sure that plugins are
loaded correctly in non-experimentals.

+  return PERMISSIONS_DEFAULT_ALLOWED.indexOf(event.permission) >= 0;
+};
+
 exports.WebView = WebView;
 exports.WebViewInternal = WebViewInternal;
 exports.CreateEvent = CreateEvent;