<webview>: Change how plugin load works inside guests.

chrome/renderer/resources/extensions/web_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Shim that simulates a <webview> tag via Mutation Observers.
 //
 // The actual tag is implemented via the browser plugin. The internals of this
 // are hidden via Shadow DOM.
 
 'use strict';
@@ skipping 93 matching lines @@
       'name'
     ]
   },
   'permissionrequest': {
     cancelable: true,
     customHandler: function(webViewInternal, event, webViewEvent) {
       webViewInternal.handlePermissionEvent_(event, webViewEvent);
     },
     evt: CreateEvent('webview.onPermissionRequest'),
     fields: [
+      'identifier',
       'lastUnlockedBySelf',
+      'name',
       'permission',
       'requestMethod',
       'url',
       'userGesture'
     ]
   },
   'responsive': {
     evt: CreateEvent('webview.onResponsive'),
     fields: ['processId']
   },
@@ skipping 496 matching lines @@
         webviewNode.addEventListener(eventName, value);
     },
     enumerable: true
   });
 };
 
 /**
  * @private
  */
 WebViewInternal.prototype.getPermissionTypes_ = function() {
-  return ['media', 'geolocation', 'pointerLock', 'download'];
+  return ['media', 'geolocation', 'pointerLock', 'download', 'loadplugin'];

[Fady Samuel, 2013/09/26 12:53:32]

We usually let new API bake a bit in canary/dev and then explicitly move it to
web_view.js once we are confident it's reasonably stable (other teams have tried
it out and it works for them, and the bots have been happy for a while). Could
you please move this permission to web_view_experimental.js? You might want to
speak to Istiaque about how we do that, I'm probably not coming into work today
as I'm still fighting a cold/flu.

[sadrul, 2013/09/26 15:28:10]

Done.

 };
 
 /**
  * @private
  */
 WebViewInternal.prototype.handleLoadCommitEvent_ =
     function(event, webViewEvent) {
   this.currentEntryIndex_ = event.currentEntryIndex;
   this.entryCount_ = event.entryCount;
   this.processId_ = event.processId;
@@ skipping 133 matching lines @@
       WebView.setPermission(self.instanceId_, requestId, false, '');
     }
   };
   webViewEvent.request = request;
 
   var defaultPrevented = !webviewNode.dispatchEvent(webViewEvent);
   if (decisionMade) {
     return;
   }
 
+  var PERMISSIONS_DEFAULT_ALLOWED = ['loadplugin'];
+  var defaultAllowed =
+      PERMISSIONS_DEFAULT_ALLOWED.indexOf(event.permission) >= 0;
   if (defaultPrevented) {
     // Make browser plugin track lifetime of |request|.
     MessagingNatives.BindToGC(request, function() {
       // Avoid showing a warning message if the decision has already been made.
       if (decisionMade) {
         return;
       }
-      WebView.setPermission(self.instanceId_, requestId, false, '');
-      showWarningMessage(event.permission);
+      WebView.setPermission(self.instanceId_, requestId, defaultAllowed, '');
+      if (!defaultAllowed)
+        showWarningMessage(event.permission);
     });
   } else {
     decisionMade = true;
-    WebView.setPermission(self.instanceId_, requestId, false, '');
-    showWarningMessage(event.permission);
+    WebView.setPermission(self.instanceId_, requestId, defaultAllowed, '');
+    if (!defaultAllowed)
+      showWarningMessage(event.permission);
   }
 };
 
 /**
  * @private
  */
 WebViewInternal.prototype.setupWebRequestEvents_ = function() {
   var self = this;
   var request = {};
   var createWebRequestEvent = function(webRequestEvent) {
@@ skipping 153 matching lines @@
 
 /**
  * Implemented when the experimental API is available.
  * @private
  */
 WebViewInternal.prototype.maybeAttachWebRequestEventToWebview_ = function() {};
 
 exports.WebView = WebView;
 exports.WebViewInternal = WebViewInternal;
 exports.CreateEvent = CreateEvent;