Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2457593002: Move remaining Document timers to frame-specific task runners. (Closed)

Created:
4 years, 1 month ago by dcheng
Modified:
4 years, 1 month ago
Reviewers:
haraken, Sami
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis, alex clarke (OOO till 29th), Sami
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move remaining Document timers to frame-specific task runners. BUG=624694 Committed: https://crrev.com/780ca8a04513033f24633a9830b49a01f116e351 Cr-Commit-Position: refs/heads/master@{#428052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 4 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
dcheng
I don't feel great about using TaskType::Internal so much, but I don't feel like there's ...
4 years, 1 month ago (2016-10-27 00:26:09 UTC) #2
haraken
LGTM Yeah, I don't find these tasks in the spec so Task::Internal would be a ...
4 years, 1 month ago (2016-10-27 01:05:37 UTC) #6
Sami
lgtm. Internal is probably the best we can do for these for now.
4 years, 1 month ago (2016-10-27 13:18:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457593002/1
4 years, 1 month ago (2016-10-27 16:35:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 16:40:01 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 16:59:20 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/780ca8a04513033f24633a9830b49a01f116e351
Cr-Commit-Position: refs/heads/master@{#428052}

Powered by Google App Engine
This is Rietveld 408576698