chrome/browser/page_load_metrics/page_load_metrics_initialize.cc - Issue 2457583007: [PageLoadMetrics] Create page load timing metrics for H2/QUIC/H1 pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2457583007: [PageLoadMetrics] Create page load timing metrics for H2/QUIC/H1 pages (Closed)

Patch Set: Address comments from PS3 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

index 2d4f07597e5443eec43d8ab8da9765f2c710ec34..055a84c0e9411b1d55a483c77106df21d60a96a4 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

@@ -20,6 +20,7 @@

#include "chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h"

+#include "chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/page_load_metrics_embedder_interface.h"

#include "chrome/browser/page_load_metrics/page_load_tracker.h"

@@ -76,7 +77,8 @@ void PageLoadMetricsEmbedder::RegisterObservers(

base::MakeUnique<ServiceWorkerPageLoadMetricsObserver>());

tracker->AddObserver(base::MakeUnique<HttpsEngagementPageLoadMetricsObserver>(

web_contents_->GetBrowserContext()));

- tracker->AddObserver(base::WrapUnique(new CssScanningMetricsObserver()));

+ tracker->AddObserver(base::MakeUnique<CssScanningMetricsObserver>());

+ tracker->AddObserver(base::MakeUnique<ProtocolPageLoadMetricsObserver>());

std::unique_ptr<page_load_metrics::PageLoadMetricsObserver>

no_state_prefetch_observer =

NoStatePrefetchPageLoadMetricsObserver::CreateIfNeeded(web_contents_);