Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: media/base/cdm_context.h

Issue 2457563002: Media Remoting: Add remoting control logic for encrypted contents. (Closed)
Patch Set: Addressed comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/cdm_context.h
diff --git a/media/base/cdm_context.h b/media/base/cdm_context.h
index d046927c72079fe8956dd104a9a3a5c9cb254422..65c0bb7a6963100b7cf88a2c8c838b7172225d07 100644
--- a/media/base/cdm_context.h
+++ b/media/base/cdm_context.h
@@ -34,6 +34,10 @@ class MEDIA_EXPORT CdmContext {
// is not supported (e.g. this CDM is a local CDM).
virtual int GetCdmId() const = 0;
+ // Returns a unique class identifier. Some subclasses override and use this
+ // method to provide safe down-casting to their type.
xhwang 2016/11/01 08:21:28 If I add a new CdmContext, how should I implement
xjz 2016/11/01 21:55:52 The implementation of this is up to each implement
xhwang 2016/11/02 06:47:05 +miu But how "unique" is unique? The current impl
+ virtual void* GetClassIdentifier() const;
xhwang 2016/11/01 08:21:28 Please see my comment in remoting_cdm.cc about the
xjz 2016/11/01 21:55:52 Replied to that comment. :)
+
protected:
CdmContext();

Powered by Google App Engine
This is Rietveld 408576698