third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2457523003: Support 'insertReplacementText' for spellcheck

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2457523003: Support 'insertReplacementText' for spellcheck (Closed)

Patch Set: fix for nit from Yosi_UTC9, Xiaocheng Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 4e2893a1d6079206e82fb4a722a7a48419da675e..11d6e09a793ce33d4f2057a2287c080dd792b7ce 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -976,8 +976,9 @@ void WebLocalFrameImpl::replaceSelection(const WebString& text) {

bool selectReplacement =

frame()->editor().behavior().shouldSelectReplacement();

bool smartReplace = true;

- frame()->editor().replaceSelectionWithText(text, selectReplacement,

- smartReplace);

+ frame()->editor().replaceSelectionWithText(

+ text, selectReplacement, smartReplace,

+ InputEvent::InputType::InsertReplacementText);

}

void WebLocalFrameImpl::setMarkedText(const WebString& text,