Support 'insertReplacementText' for spellcheck

third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 10 matching lines @@
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "core/editing/spellcheck/SpellChecker.h"
 
 #include "core/HTMLNames.h"
 #include "core/InputTypeNames.h"
+#include "core/clipboard/DataObject.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/ElementTraversal.h"
 #include "core/dom/NodeTraversal.h"
+#include "core/dom/Range.h"
 #include "core/editing/EditingUtilities.h"
 #include "core/editing/Editor.h"
 #include "core/editing/EphemeralRange.h"
 #include "core/editing/VisibleUnits.h"
 #include "core/editing/commands/CompositeEditCommand.h"
 #include "core/editing/commands/ReplaceSelectionCommand.h"
 #include "core/editing/commands/TypingCommand.h"
 #include "core/editing/iterators/CharacterIterator.h"
 #include "core/editing/markers/DocumentMarkerController.h"
 #include "core/editing/spellcheck/SpellCheckRequester.h"
@@ skipping 765 matching lines @@
   if (markers.size() < 1 ||
       markers[0]->startOffset() >= markers[0]->endOffset())
     return;
   EphemeralRange markerRange =
       EphemeralRange(Position(caretRange.startPosition().computeContainerNode(),
                               markers[0]->startOffset()),
                      Position(caretRange.endPosition().computeContainerNode(),
                               markers[0]->endOffset()));
   if (markerRange.isNull())
     return;
+
   frame().selection().setSelection(
       SelectionInDOMTree::Builder().setBaseAndExtent(markerRange).build());
 
+  // Dispatch 'beforeinput'.
+  Element* target = frame().editor().findEventTargetFromSelection();
+  RangeVector* ranges = new RangeVector(1, frame().selection().firstRange());

[yosin_UTC9, 2016/11/10 01:49:52]

Is this work if |FrameSelection::firstRange()| returns null?

Since |FrameSelection::setSelection()| can invoke JS, DOM tree can be gone away
here.

[Xiaocheng, 2016/11/10 02:35:53]

This seems to be a bug that we introduced. When hoisting layout updates, we did
not check whether DOM is gone after FS::setSelection(), and just called
updateSAL directly.

+  DataTransfer* dataTransfer = DataTransfer::create(
+      DataTransfer::DataTransferType::InsertReplacementText,
+      DataTransferAccessPolicy::DataTransferReadable,
+      DataObject::createFromString(text));
+
+  const bool cancel =
+      dispatchBeforeInputDataTransfer(
+          target, InputEvent::InputType::InsertReplacementText, dataTransfer,
+          ranges) != DispatchEventResult::NotCanceled;
+
+  // 'beforeinput' event handler may destroy target frame.
+  if (frame().document()->frame() != m_frame)
+    return;
+
   // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
   // needs to be audited.  See http://crbug.com/590369 for more details.
   frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
 
-  frame().editor().replaceSelectionWithText(text, false, false);
+  if (cancel)

[Xiaocheng, 2016/11/10 02:35:53]

Let's move this return to be before updateStyleAndLayout... so that layout is
updated less frequently.

+    return;
+  frame().editor().replaceSelectionWithText(
+      text, false, false, InputEvent::InputType::InsertReplacementText);
 }
 
 static bool shouldCheckOldSelection(const Position& oldSelectionStart) {
   if (!oldSelectionStart.isConnected())
     return false;
   if (isPositionInTextField(oldSelectionStart))
     return false;
   if (isPositionInTextArea(oldSelectionStart))
     return true;
 
@@ skipping 302 matching lines @@
         startOfNextParagraph(createVisiblePosition(paragraphEnd));
     paragraphStart = newParagraphStart.toParentAnchoredPosition();
     paragraphEnd = endOfParagraph(newParagraphStart).toParentAnchoredPosition();
     firstIteration = false;
     totalLengthProcessed += currentLength;
   }
   return std::make_pair(firstFoundItem, firstFoundOffset);
 }
 
 }  // namespace blink