Support 'insertReplacementText' for spellcheck

third_party/WebKit/Source/core/testing/Internals.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 1773 matching lines @@
 
   HeapVector<Member<Node>> matches;
   HitTestResult result(request, point, topPadding, rightPadding, bottomPadding,
                        leftPadding);
   layoutViewItem.hitTest(result);
   copyToVector(result.listBasedTestResult(), matches);
 
   return StaticNodeList::adopt(matches);
 }
 
+void Internals::setSpellingMarker(Document* document) {
+  DCHECK(document);

[yosin_UTC9, 2016/10/28 04:06:14]

Please throw an exception rather than DCHECK().
ClusterFuzz sometime includes a method in Internals.idl.

+  DCHECK(document->frame());
+

[Xiaocheng, 2016/10/28 02:55:24]

Please call |document->updateStyleAndLayoutIgnorePendingStylesheet()| here,
because selection normalization requires clean layout.

+  EphemeralRange range =
+      document->frame()->selection().selection().toNormalizedEphemeralRange();
+  document->markers().addMarker(range.startPosition(), range.endPosition(),
+                                DocumentMarker::Spelling);
+  document->updateStyleAndLayoutIgnorePendingStylesheets();

[Xiaocheng, 2016/10/28 02:55:24]

I don't think we should update layout here.

+}
+
 bool Internals::hasSpellingMarker(Document* document, int from, int length) {
   ASSERT(document);
   if (!document->frame())
     return false;
 
   document->updateStyleAndLayoutIgnorePendingStylesheets();
   return document->frame()->spellChecker().selectionStartHasMarkerFor(
       DocumentMarker::Spelling, from, length);
 }
 
 void Internals::setSpellCheckingEnabled(bool enabled) {
   if (!contextDocument() || !contextDocument()->frame())
     return;
 
   if (enabled !=
       contextDocument()->frame()->spellChecker().isSpellCheckingEnabled())
     contextDocument()->frame()->spellChecker().toggleSpellCheckingEnabled();
 }
 
+void Internals::replaceMisspelled(Document* document,
+                                  const String& replacement) {
+  DCHECK(document);

[yosin_UTC9, 2016/10/28 04:06:14]

Please throw an exception rather than DCHECK().
ClusterFuzz sometime includes a method in Internals.idl.

+  DCHECK(document->frame());
+

[Xiaocheng, 2016/10/28 02:55:23]

Please call document->updateStyleAndLayoutIgnorePendingStylesheet() here, as
SpellChecker::replaceMisspelledRange() requires clean layout.

+  document->frame()->spellChecker().replaceMisspelledRange(replacement);
+}
+
 bool Internals::canHyphenate(const AtomicString& locale) {
   return LayoutLocale::valueOrDefault(LayoutLocale::get(locale))
       .getHyphenation();
 }
 
 void Internals::setMockHyphenation(const AtomicString& locale) {
   LayoutLocale::setHyphenationForTesting(locale, adoptRef(new MockHyphenation));
 }
 
 bool Internals::isOverwriteModeEnabled(Document* document) {
@@ skipping 1186 matching lines @@
     return ClientRect::create();
 
   return ClientRect::create(FloatRect(node->layoutObject()->visualRect()));
 }
 
 void Internals::crash() {
   CHECK(false) << "Intentional crash";
 }
 
 }  // namespace blink