src/tracing/trace-event.cc - Issue 2457523002: [Tracing] Fix inaccurate timer calculation in runtime statistics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/tracing/trace-event.cc

Issue 2457523002: [Tracing] Fix inaccurate timer calculation in runtime statistics. (Closed)

Patch Set: Address cbruni's comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/tracing/trace-event.cc

diff --git a/src/tracing/trace-event.cc b/src/tracing/trace-event.cc

index a24ebc0d975b2fb75c61fc30b2d4b8db74315b74..ebee5345997756c3a77fc902eac3089de7b16369 100644

--- a/src/tracing/trace-event.cc

+++ b/src/tracing/trace-event.cc

@@ -49,7 +49,7 @@ void CallStatsScopedTracer::Initialize(v8::internal::Isolate* isolate,

p_data_ = &data_;

RuntimeCallStats* table = isolate->counters()->runtime_call_stats();

has_parent_scope_ = table->InUse();

- if (!has_parent_scope_) table->Reset();

+ if (!has_parent_scope_ && table->current_timer() == NULL) table->Reset();

v8::internal::tracing::AddTraceEvent(

TRACE_EVENT_PHASE_BEGIN, category_group_enabled, name,

v8::internal::tracing::kGlobalScope, v8::internal::tracing::kNoId,

« no previous file with comments | « src/counters.cc ('k') | no next file » | no next file with comments »