Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: chrome/test/data/webui/settings/people_page_test.js

Issue 2457483002: [MD Settings][Sync Settings] Updates sync status messages (Closed)
Patch Set: Addressed rogerta's comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/people_page_test.js
diff --git a/chrome/test/data/webui/settings/people_page_test.js b/chrome/test/data/webui/settings/people_page_test.js
index d29f76905fd6f8fb68ebe0954d763ba9546fcad2..748bb6990f2d4859cfa148631f2a8457f40ff389 100644
--- a/chrome/test/data/webui/settings/people_page_test.js
+++ b/chrome/test/data/webui/settings/people_page_test.js
@@ -230,8 +230,8 @@ cr.define('settings_people_page', function() {
});
});
- test('CustomizeSyncDisabledForManagedSignin', function() {
- assertFalse(!!peoplePage.$$('#customize-sync'));
+ test('syncStatusNotActionableForManagedAccounts', function() {
+ assertFalse(!!peoplePage.$$('#sync-status'));
return browserProxy.whenCalled('getSyncStatus').then(function() {
cr.webUIListenerCallback('sync-status-changed', {
@@ -240,9 +240,9 @@ cr.define('settings_people_page', function() {
});
Polymer.dom.flush();
- var customizeSync = peoplePage.$$('#customize-sync');
- assertTrue(!!customizeSync);
- assertTrue(customizeSync.hasAttribute('actionable'));
+ var syncStatusContainer = peoplePage.$$('#sync-status');
+ assertTrue(!!syncStatusContainer);
+ assertTrue(syncStatusContainer.hasAttribute('actionable'));
cr.webUIListenerCallback('sync-status-changed', {
managed: true,
@@ -251,9 +251,39 @@ cr.define('settings_people_page', function() {
});
Polymer.dom.flush();
- var customizeSync = peoplePage.$$('#customize-sync');
- assertTrue(!!customizeSync);
- assertFalse(customizeSync.hasAttribute('actionable'));
+ var syncStatusContainer = peoplePage.$$('#sync-status');
+ assertTrue(!!syncStatusContainer);
+ assertFalse(syncStatusContainer.hasAttribute('actionable'));
+ });
+ });
+
+ test('syncStatusNotActionableForPassiveErrors', function() {
+ assertFalse(!!peoplePage.$$('#sync-status'));
+
+ return browserProxy.whenCalled('getSyncStatus').then(function() {
+ cr.webUIListenerCallback('sync-status-changed', {
+ hasError: true,
+ statusAction: settings.StatusAction.NO_ACTION,
+ signedIn: true,
+ syncSystemEnabled: true,
+ });
+ Polymer.dom.flush();
+
+ var syncStatusContainer = peoplePage.$$('#sync-status');
+ assertTrue(!!syncStatusContainer);
+ assertFalse(syncStatusContainer.hasAttribute('actionable'));
+
+ cr.webUIListenerCallback('sync-status-changed', {
+ hasError: true,
+ statusAction: settings.StatusAction.UPGRADE_CLIENT,
+ signedIn: true,
+ syncSystemEnabled: true,
+ });
+ Polymer.dom.flush();
+
+ var syncStatusContainer = peoplePage.$$('#sync-status');
+ assertTrue(!!syncStatusContainer);
+ assertTrue(syncStatusContainer.hasAttribute('actionable'));
});
});
});

Powered by Google App Engine
This is Rietveld 408576698