Initialize ICU before running HPKP fuzzers.

Initialize ICU before running HPKP fuzzers.

Add a net_fuzzer_test_support dependency to the HPKP fuzzers to initialize ICU.

BUG=659878
Committed: https://crrev.com/15387afb2a0737dc7f78ac4fe3f50f3cb7128399
Cr-Commit-Position: refs/heads/master@{#428166}

[martijnc, 2016-10-27 20:22:21]

Description was changed from

==========
Initialize ICU before running HPKP fuzzers.

BUG=659878
==========

to

==========
Initialize ICU before running HPKP fuzzers.

Add a net_fuzzer_test_support dependency to the HPKP fuzzers to initialize ICU.

BUG=659878
==========

[martijnc, 2016-10-27 20:22:21]

martijn@martijnc.be changed reviewers:
+ davidben@chromium.org

[martijnc, 2016-10-27 20:24:43]

The HPKP fuzzers are triggering a CHECK because ICU isn't initialized (see bug).

Adding the dependency should fix that. Can you take a look?

Thanks!

[davidben, 2016-10-27 20:32:00]

davidben@chromium.org changed reviewers:
+ mmenke@chromium.org

[davidben, 2016-10-27 20:32:01]

+mmenke probably knows more about ICU stuff. (This is probably correct, but Matt
would know for sure.)

[mmenke, 2016-10-27 20:59:41]

On 2016/10/27 20:32:01, davidben wrote:
> +mmenke probably knows more about ICU stuff. (This is probably correct, but
Matt
> would know for sure.)

I wouldn't say I know about ICU stuff, but I do know
net/base/fuzzer_test_support.cc initializes it when you depend on it, so LGTM.

[martijnc, 2016-10-27 21:03:46]

The CQ bit was checked by martijn@martijnc.be

[commit-bot: I haz the power, 2016-10-27 21:05:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 22:21:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-27 22:24:36]

Description was changed from

==========
Initialize ICU before running HPKP fuzzers.

Add a net_fuzzer_test_support dependency to the HPKP fuzzers to initialize ICU.

BUG=659878
==========

to

==========
Initialize ICU before running HPKP fuzzers.

Add a net_fuzzer_test_support dependency to the HPKP fuzzers to initialize ICU.

BUG=659878

Committed: https://crrev.com/15387afb2a0737dc7f78ac4fe3f50f3cb7128399
Cr-Commit-Position: refs/heads/master@{#428166}
==========

[commit-bot: I haz the power, 2016-10-27 22:24:37]

Patchset 1 (id:??) landed as
https://crrev.com/15387afb2a0737dc7f78ac4fe3f50f3cb7128399
Cr-Commit-Position: refs/heads/master@{#428166}