Fix detection of BUILTIN functions

Fix detection of BUILTIN functions

In the asm.js to wasm pipeline, we generate an entry function with
BUILTIN code, but still attached to a TYPE_NORMAL script.
This fix avoids trying to set a breakpoint there, resulting in a crash
on DCHECK(shared->HasDebugInfo()).

Also add two inspector tests to track regressions.

BUG=v8:5568
R=titzer@chromium.org,mstarzinger@chromium.org

Committed: https://crrev.com/1cac34ed6b98ce756568009bd4082f17aadbb256
Cr-Commit-Position: refs/heads/master@{#40633}

[Clemens Hammacher, 2016-10-26 14:58:51]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 14:58:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-10-26 15:01:00]

Description was changed from

==========
Fix detection of BUILTIN functions

In the asm.js to wasm pipeline, we generate an entry function with
BUILTIN code, but still attached to a TYPE_NORMAL script.
This fix avoids trying to set a breakpoint there, resulting in a crash
on DCHECK(shared->HasDebugInfo()).

BUG=v8:5568
R=titzer@chromium.org,mstarzinger@chromium.org
==========

to

==========
Fix detection of BUILTIN functions

In the asm.js to wasm pipeline, we generate an entry function with
BUILTIN code, but still attached to a TYPE_NORMAL script.
This fix avoids trying to set a breakpoint there, resulting in a crash
on DCHECK(shared->HasDebugInfo()).

Also add two inspector tests to track regressions.

BUG=v8:5568
R=titzer@chromium.org,mstarzinger@chromium.org
==========

[commit-bot: I haz the power, 2016-10-26 15:15:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 15:15:34]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[Clemens Hammacher, 2016-10-26 15:49:13]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 15:49:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 16:07:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 16:07:30]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/11544)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[Clemens Hammacher, 2016-10-26 16:14:21]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 16:14:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 16:45:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 16:45:09]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-10-26 18:11:39]

mstarzinger@chromium.org changed reviewers:
+ yangguo@chromium.org

[Michael Starzinger, 2016-10-26 18:11:39]

I'm not familiar enough with the code. Delegating to Yang.

[titzer, 2016-10-26 18:17:21]

On 2016/10/26 18:11:39, Michael Starzinger wrote:
> I'm not familiar enough with the code. Delegating to Yang.

Something looks weird with the patchset, like files got added twice.

[Clemens Hammacher, 2016-10-26 19:10:57]

On 2016/10/26 18:17:21, titzer wrote:
> On 2016/10/26 18:11:39, Michael Starzinger wrote:
> > I'm not familiar enough with the code. Delegating to Yang.
> 
> Something looks weird with the patchset, like files got added twice.

Nope, it's two added tests, plus two expected outputs.
One test adds break points when the script is parsed, before executing it, the
other one sets breakpoints while the script is being executed.
The output might change once we land the CL that disables the asm.js to wasm
pipeline if the debugger is active. The important thing for now is that it does
not crash in either case :)

The actual change of this CL is in SharedFunctionInfo::IsSubjectToDebugging() in
objects-inl.h.

[Yang, 2016-10-28 05:08:29]

LGTM.

[Clemens Hammacher, 2016-10-28 05:56:02]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-10-28 05:56:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 06:48:04]

Description was changed from

==========
Fix detection of BUILTIN functions

In the asm.js to wasm pipeline, we generate an entry function with
BUILTIN code, but still attached to a TYPE_NORMAL script.
This fix avoids trying to set a breakpoint there, resulting in a crash
on DCHECK(shared->HasDebugInfo()).

Also add two inspector tests to track regressions.

BUG=v8:5568
R=titzer@chromium.org,mstarzinger@chromium.org
==========

to

==========
Fix detection of BUILTIN functions

In the asm.js to wasm pipeline, we generate an entry function with
BUILTIN code, but still attached to a TYPE_NORMAL script.
This fix avoids trying to set a breakpoint there, resulting in a crash
on DCHECK(shared->HasDebugInfo()).

Also add two inspector tests to track regressions.

BUG=v8:5568
R=titzer@chromium.org,mstarzinger@chromium.org
==========

[commit-bot: I haz the power, 2016-10-28 06:48:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 22:16:07]

Description was changed from

==========
Fix detection of BUILTIN functions

In the asm.js to wasm pipeline, we generate an entry function with
BUILTIN code, but still attached to a TYPE_NORMAL script.
This fix avoids trying to set a breakpoint there, resulting in a crash
on DCHECK(shared->HasDebugInfo()).

Also add two inspector tests to track regressions.

BUG=v8:5568
R=titzer@chromium.org,mstarzinger@chromium.org
==========

to

==========
Fix detection of BUILTIN functions

In the asm.js to wasm pipeline, we generate an entry function with
BUILTIN code, but still attached to a TYPE_NORMAL script.
This fix avoids trying to set a breakpoint there, resulting in a crash
on DCHECK(shared->HasDebugInfo()).

Also add two inspector tests to track regressions.

BUG=v8:5568
R=titzer@chromium.org,mstarzinger@chromium.org

Committed: https://crrev.com/1cac34ed6b98ce756568009bd4082f17aadbb256
Cr-Commit-Position: refs/heads/master@{#40633}
==========

[commit-bot: I haz the power, 2016-11-17 22:16:09]

Patchset 3 (id:??) landed as
https://crrev.com/1cac34ed6b98ce756568009bd4082f17aadbb256
Cr-Commit-Position: refs/heads/master@{#40633}