[ash-md] Added ink drop to system menu rows that inherit from ActionableView.

[ash-md] Added ink drop to system menu rows that inherit from ActionableView.

Depends on: https://codereview.chromium.org/2468533002/

This CL adds an ink drop to the following system menu rows:

- Settings default row
- Caps lock default row
- Tracing default row
- OS Update default row
- SMS default row
- Bluetooth default row
- Cast default row
- Accessibility default row
- IME default row
- Network default row
- Display rotation lock default row
- VPN default row

BUG=642845
Committed: https://crrev.com/b82b2f57004cdb923e7586d3a9ed7401da929a11
Cr-Commit-Position: refs/heads/master@{#429325}

[bruthig, 2016-10-31 22:15:04]

bruthig@chromium.org changed reviewers:
+ tdanderson@chromium.org

[bruthig, 2016-10-31 22:15:05]

Terry, can you please take a look?

[tdanderson, 2016-11-01 19:49:18]

LGTM

https://codereview.chromium.org/2457393006/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/actionable_view.cc (right):

https://codereview.chromium.org/2457393006/diff/20001/ash/common/system/tray/...
ash/common/system/tray/actionable_view.cc:26:
set_notify_enter_exit_on_child(true);
Should this be gated behind IsSystemTrayMenuMaterial()?

https://codereview.chromium.org/2457393006/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/actionable_view.h (right):

https://codereview.chromium.org/2457393006/diff/20001/ash/common/system/tray/...
ash/common/system/tray/actionable_view.h:10: #include "ui/gfx/geometry/rect.h"
Is this needed?

[bruthig, 2016-11-01 21:10:54]

https://codereview.chromium.org/2457393006/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/actionable_view.cc (right):

https://codereview.chromium.org/2457393006/diff/20001/ash/common/system/tray/...
ash/common/system/tray/actionable_view.cc:26:
set_notify_enter_exit_on_child(true);
On 2016/11/01 19:49:18, tdanderson wrote:
> Should this be gated behind IsSystemTrayMenuMaterial()?

It shouldn't affect non-md.  The only ActionableView classes to override
OnMouseEntered()/OnMouseExited() are HoverHighlightView and
TrayPopupItemContainer, both of which call set_notify_enter_exit_on_child(true)
already.

https://codereview.chromium.org/2457393006/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/actionable_view.h (right):

https://codereview.chromium.org/2457393006/diff/20001/ash/common/system/tray/...
ash/common/system/tray/actionable_view.h:10: #include "ui/gfx/geometry/rect.h"
On 2016/11/01 19:49:18, tdanderson wrote:
> Is this needed?

Ya, not because of my change though.  GetFocusBounds() returns the Rect type on
line 48.

[bruthig, 2016-11-01 21:10:57]

The CQ bit was checked by bruthig@chromium.org

[commit-bot: I haz the power, 2016-11-01 21:11:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 21:15:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 21:15:10]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tdanderson, 2016-11-01 21:53:54]

https://codereview.chromium.org/2457393006/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/actionable_view.cc (right):

https://codereview.chromium.org/2457393006/diff/20001/ash/common/system/tray/...
ash/common/system/tray/actionable_view.cc:26:
set_notify_enter_exit_on_child(true);
On 2016/11/01 21:10:54, bruthig wrote:
> On 2016/11/01 19:49:18, tdanderson wrote:
> > Should this be gated behind IsSystemTrayMenuMaterial()?
> 
> It shouldn't affect non-md.  The only ActionableView classes to override
> OnMouseEntered()/OnMouseExited() are HoverHighlightView and
> TrayPopupItemContainer, both of which call
set_notify_enter_exit_on_child(true)
> already.

Acknowledged.

https://codereview.chromium.org/2457393006/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/actionable_view.h (right):

https://codereview.chromium.org/2457393006/diff/20001/ash/common/system/tray/...
ash/common/system/tray/actionable_view.h:10: #include "ui/gfx/geometry/rect.h"
On 2016/11/01 21:10:54, bruthig wrote:
> On 2016/11/01 19:49:18, tdanderson wrote:
> > Is this needed?
> 
> Ya, not because of my change though.  GetFocusBounds() returns the Rect type
on
> line 48.

Acknowledged.

[bruthig, 2016-11-02 13:51:41]

The CQ bit was checked by bruthig@chromium.org

[bruthig, 2016-11-02 13:51:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2457393006/#ps40001
(title: "Merge branch 'master' into ink_drop_on_system_menu")

[commit-bot: I haz the power, 2016-11-02 13:52:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 14:28:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 14:28:05]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bruthig, 2016-11-02 14:31:21]

The CQ bit was checked by bruthig@chromium.org

[commit-bot: I haz the power, 2016-11-02 14:31:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 15:24:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 15:24:38]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bruthig, 2016-11-02 16:38:33]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 16:39:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bruthig, 2016-11-02 16:41:08]

Terry, can you take a quick look at the changes in patch set 4?

[tdanderson, 2016-11-02 17:27:18]

On 2016/11/02 16:41:08, bruthig wrote:
> Terry, can you take a quick look at the changes in patch set 4?

patch set 4 still lgtm

[commit-bot: I haz the power, 2016-11-02 17:28:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 17:28:22]

Dry run: This issue passed the CQ dry run.

[bruthig, 2016-11-02 17:30:39]

The CQ bit was checked by bruthig@chromium.org

[commit-bot: I haz the power, 2016-11-02 17:31:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 17:37:58]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-02 17:56:40]

Description was changed from

==========
[ash-md] Added ink drop to system menu rows that inherit from ActionableView.

Depends on: https://codereview.chromium.org/2468533002/

This CL adds an ink drop to the following system menu rows:

- Settings default row
- Caps lock default row
- Tracing default row
- OS Update default row
- SMS default row
- Bluetooth default row
- Cast default row
- Accessibility default row
- IME default row
- Network default row
- Display rotation lock default row
- VPN default row

BUG=642845
==========

to

==========
[ash-md] Added ink drop to system menu rows that inherit from ActionableView.

Depends on: https://codereview.chromium.org/2468533002/

This CL adds an ink drop to the following system menu rows:

- Settings default row
- Caps lock default row
- Tracing default row
- OS Update default row
- SMS default row
- Bluetooth default row
- Cast default row
- Accessibility default row
- IME default row
- Network default row
- Display rotation lock default row
- VPN default row

BUG=642845

Committed: https://crrev.com/b82b2f57004cdb923e7586d3a9ed7401da929a11
Cr-Commit-Position: refs/heads/master@{#429325}
==========

[commit-bot: I haz the power, 2016-11-02 17:56:41]

Patchset 4 (id:??) landed as
https://crrev.com/b82b2f57004cdb923e7586d3a9ed7401da929a11
Cr-Commit-Position: refs/heads/master@{#429325}